Opened 17 months ago

Closed 16 months ago

Last modified 12 months ago

#7327 closed change (fixed)

Update options.showOptions calls to use Promises — at Version 10

Reported by: kzar Assignee: kzar
Priority: P3 Milestone:
Module: User-Interface Keywords:
Cc: greiner, sebastian Blocked By:
Blocking: #6936 Platform: Unknown / Cross platform
Ready: yes Confidential: no
Tester: Unknown Verified working: yes
Review URL(s):

https://gitlab.com/eyeo/adblockplus/abpui/adblockplusui/merge_requests/237
https://gitlab.com/eyeo/adblockplus/abpui/adblockpluschrome/merge_requests/18

Description (last modified by kzar)

Background

With #7271 we are updating our use of the browser.* APIs to use Promises instead of callbacks where possible. Generally the changes are trivial, but it made sense to restructure some of the options.showOptions logic around Promises too.

What to change

  • Update options.showOptions calls to make use of the returned Promise, instead of passing in a callback function.
  • Update the mock showOptions function in background.js

See also ui#348.

Integration notes

showOptions() in lib/options.js is expected to return a Promise.

Change History (10)

comment:1 Changed 17 months ago by greiner

  • Description modified (diff)
  • Priority changed from Unknown to P3
  • Ready set

comment:2 Changed 17 months ago by kzar

  • Owner set to kzar

comment:3 Changed 17 months ago by kzar

  • Review URL(s) modified (diff)
  • Status changed from new to reviewing

comment:4 Changed 17 months ago by greiner

  • Blocking 6936 added
  • Resolution set to fixed
  • Status changed from reviewing to closed

comment:5 Changed 16 months ago by greiner

  • Description modified (diff)

Added integration notes.

comment:6 Changed 16 months ago by greiner

  • Resolution fixed deleted
  • Status changed from closed to reopened

Reopening the ticket to make the necessary changes to our adblockpluschrome fork.

comment:7 Changed 16 months ago by greiner

  • Review URL(s) modified (diff)
  • Status changed from reopened to reviewing

comment:8 Changed 16 months ago by greiner

  • Resolution set to fixed
  • Status changed from reviewing to closed

comment:9 Changed 16 months ago by kzar

  • Blocking 7271 removed

comment:10 Changed 16 months ago by kzar

  • Description modified (diff)
  • Ready unset

We need to rethink this API, see the discussion here.

Note: See TracTickets for help on using tickets.