Changes between Version 9 and Version 10 of Ticket #7338


Ignore:
Timestamp:
03/26/2019 01:54:09 PM (17 months ago)
Author:
kzar
Comment:

Legend:

Unmodified
Added
Removed
Modified
  • Ticket #7338 – Description

    v9 v10  
    1111- In `lib/utils.js` we use `document.addEventListener`, `document.removeEventListener` and `document.readyState` in order to provide `Utils.runAsync` which is used by the core code. Once we stop using `runAsync` with #7406, we can remove this code. 
    1212 
    13 - In `lib/icon.js` we use `Image` to load the icon images, then `document.createElement` to create a `canvas` with their contents as an optimisation (#7253). No plan so far. 
     13- In `lib/icon.js` we use `Image` to load the icon images, then `document.createElement` to create a `canvas` with their contents as an optimisation (#7253). We'll need to pass the image paths to the `browserAction` APIs instead. 
    1414- In `lib/filterValidation.js` we use `document.createElement`, `document.documentElement.appendChild`, `document.documentElement.removeChild` and `document.querySelector` to create a `style` element which we use to test if a given CSS selector is valid. No plan so far. 
    1515- In `lib/notificationHelper.js` we use `window.confirm` as a fall back for question notifications, where the `Notification` API is faulty/unavailable. No plan so far.