Changes between Version 15 and Version 16 of Ticket #7338


Ignore:
Timestamp:
03/26/2019 04:47:48 PM (17 months ago)
Author:
kzar
Comment:

Legend:

Unmodified
Added
Removed
Modified
  • Ticket #7338 – Description

    v15 v16  
    1313 
    1414- In `lib/icon.js` we use `Image` to load the icon images, then `document.createElement` to create a `canvas` with their contents as an optimisation (#7253). We'll need to pass the image paths to the `browserAction` APIs instead. 
    15 - In `lib/filterValidation.js` we use `document.createElement`, `document.documentElement.appendChild`, `document.documentElement.removeChild` and `document.querySelector` to create a `style` element which we use to test if a given CSS selector is valid. No plan so far. 
     15- In `lib/filterValidation.js` we use `document.createElement`, `document.documentElement.appendChild`, `document.documentElement.removeChild` and `document.querySelector` to create a `style` element which we use to test if a given CSS selector is valid. No plan so far, we'll need to attempt to validate CSS selectors ourselves - perhaps with a big regexp. 
    1616 
    1717=== Notes ===