Changes between Version 18 and Version 22 of Ticket #7338


Ignore:
Timestamp:
03/29/2019 10:46:14 AM (17 months ago)
Author:
kzar
Comment:

Alright, that works for me. We have a plan!

Legend:

Unmodified
Added
Removed
Modified
  • Ticket #7338

    • Property Cc greiner added
    • Property Blocked By changed from 7371, 7381, 7406, 7408 to 7371, 7381, 7406, 7408, 7423
  • Ticket #7338 – Description

    v18 v22  
    1111- In `lib/utils.js` we use `document.addEventListener`, `document.removeEventListener` and `document.readyState` in order to provide `Utils.runAsync` which is used by the core code. Once we stop using `runAsync` with #7406, we can remove this code. 
    1212- In `lib/notificationHelper.js` we use `window.confirm` as a fall back for question notifications, where the `browser.notifications` API is faulty/unavailable. We plan to remove this fallback with #7408. 
    13  
    14 - In `lib/icon.js` we use `Image` to load the icon images, then `document.createElement` to create a `canvas` with their contents as an optimisation (#7253). We'll need to use a combination of the `fetch` and `OffscreenCanvas` APIs instead, falling back to just setting the image path on browers which don't yet support `OffscreenCanvas`. 
    15 - In `lib/filterValidation.js` we use `document.createElement`, `document.documentElement.appendChild`, `document.documentElement.removeChild` and `document.querySelector` to create a `style` element which we use to test if a given CSS selector is valid. No plan so far, we'll need to attempt to validate CSS selectors ourselves - perhaps with a big regexp. 
     13- In `lib/filterValidation.js` we use `document.createElement`, `document.documentElement.appendChild`, `document.documentElement.removeChild` and `document.querySelector` to create a `style` element which we use to test if a given CSS selector is valid. We're going to remove the `filterValidation` module, once we have stopped using it with #7423. 
     14- In `lib/icon.js` we use `Image` to load the icon images, then `document.createElement` to create a `canvas` with their contents as an optimisation (#7253). We'll need to use a combination of the `fetch` and `OffscreenCanvas` APIs instead, also providing a polyfill using a canvas element for browsers which don't yet support `OffscreenCanvas`. 
    1615 
    1716=== Notes ===