Changes between Version 26 and Version 28 of Ticket #7338


Ignore:
Timestamp:
04/02/2019 10:46:42 AM (16 months ago)
Author:
kzar
Comment:

Legend:

Unmodified
Added
Removed
Modified
  • Ticket #7338

    • Property Milestone changed from to Adblock-Plus-for-Chrome-Opera-Firefox-next
  • Ticket #7338 – Description

    v26 v28  
    1818=== Notes === 
    1919To confirm which APIs might not exist in Service Workers you can change the ESLint environment from `browser` to `serviceworker` for our scripts which run in the background page. But note, I found false positives were flagged, specifically: `URL`, `console.error`, `console.trace`, `fetch` and `indexedDB`. 
     20 
     21=== Hints for testers === 
     22- Check that notifications work correctly on all the supported platforms, including old versions (e.g. 49) of Chrome and Edge. Note that we no longer expect question notifications to be shown on Edge. 
     23- Check that all the icon functionality works correctly, for example that the icon is shown, that it is greyed out for whitelisted pages and that an animation is shown for appropriate notifications. Again, take special care to test with Chrome 49 and Edge as well as the other platforms. 
     24- Check that $sitekey whitelisting still works correctly.