Opened 9 months ago

Closed 9 months ago

Last modified 6 months ago

#7343 closed change (fixed)

Update adblockplusui dependency to f24c0b314ac8 (release-2018-5.-5)

Reported by: greiner Assignee: kzar
Priority: P2 Milestone: Adblock-Plus-for-Chrome-Opera-Firefox-next
Module: Platform Keywords:
Cc: snoack, hfiguiere, kzar Blocked By: #7272, #7365, #7366
Blocking: Platform: Unknown / Cross platform
Ready: yes Confidential: no
Tester: Unknown Verified working: yes
Review URL(s):

https://gitlab.com/eyeo/adblockplus/adblockpluschrome/merge_requests/48

Description (last modified by kzar)

Background

This dependency update ensures that none of the currently used UI code passes callbacks anymore when calling extension APIs.

This imports the following changes:


What to change

Change adblockplusui dependency to hg:f24c0b314ac8 git:22c1ea9

Integration notes

browser.tabs.captureVisibleTab needs to be added to the list in polyfill.js so that it returns a promise (see #7366).

Hints for testers

Change History (15)

comment:1 Changed 9 months ago by greiner

  • Blocked By 7272 added

comment:2 Changed 9 months ago by greiner

  • Cc snoack hfiguiere added
  • Description modified (diff)

comment:3 Changed 9 months ago by greiner

  • Summary changed from Update adblockplusui dependency to TBD (release-2019-1.-9) to Update adblockplusui dependency to TBD (release-2018-5.-5)

Renamed release to indicate that it's going to land before #6936.

comment:4 Changed 9 months ago by greiner

  • Blocked By 7365 added

comment:5 Changed 9 months ago by greiner

  • Blocked By 7366 added

comment:6 Changed 9 months ago by greiner

  • Description modified (diff)

Added integration notes.

comment:7 Changed 9 months ago by greiner

  • Description modified (diff)
  • Summary changed from Update adblockplusui dependency to TBD (release-2018-5.-5) to Update adblockplusui dependency to f24c0b314ac8 (release-2018-5.-5)

Added hashes to ticket description.

comment:8 Changed 9 months ago by kzar

  • Cc kzar added
  • Description modified (diff)
  • Priority changed from Unknown to P2

Issue looks good, except I don't see the change for #7366 included in this dependency update. Was that omitted deliberately?

comment:9 Changed 9 months ago by kzar

  • Description modified (diff)
  • Owner set to kzar
  • Ready set

comment:10 Changed 9 months ago by kzar

  • Review URL(s) modified (diff)

comment:11 Changed 9 months ago by kzar

  • Status changed from new to reviewing

comment:12 Changed 9 months ago by abpbot

A commit referencing this issue has landed:
Issue 7343 - Update adblockplusui dependency to f24c0b314ac8

comment:13 Changed 9 months ago by kzar

  • Milestone set to Adblock-Plus-for-Chrome-Opera-Firefox-next
  • Resolution set to fixed
  • Status changed from reviewing to closed

comment:14 Changed 9 months ago by greiner

Just for the record: #7366 is not part of this dependency update because it only affects the UI fork of adblockpluschrome which is used to build the UI Nightlies. Instead, the change was taken care of as mentioned in the integration notes.

comment:15 Changed 6 months ago by ukacar

  • Verified working set
Note: See TracTickets for help on using tickets.