Opened 4 months ago

Closed 6 weeks ago

#7344 closed change (fixed)

Remove handling of "Fixes XXXX - ..." commit messages

Reported by: sebastian Assignee: kvas
Priority: P3 Milestone:
Module: Sitescripts Keywords:
Cc: kvas, rhowell Blocked By:
Blocking: Platform: Unknown / Cross platform
Ready: yes Confidential: no
Tester: Unknown Verified working: no
Review URL(s):

https://codereview.adblockplus.org/30048555/

Description

Background

With #3681 we added support for commit messages like "Fixes XXXX - ..." which would cause the commit to be referenced in the respective issue on Trac, and the issue to be closed if set up accordingly (which it never was). However, since it was never was set up to actually close the issue, it was rarely used to reference issues on Trac, but it's now conflicting with the notation used to reference issues on GitLab, potentially causing comments about unrelated commits being posted to old issues on Trac.

What to change

Revert the changes implemented in #3681.

Change History (5)

comment:1 Changed 2 months ago by kvas

  • Owner set to kvas

comment:2 Changed 2 months ago by kvas

  • Priority changed from Unknown to P3
  • Ready set

comment:3 Changed 2 months ago by kvas

  • Review URL(s) modified (diff)
  • Status changed from new to reviewing

comment:4 Changed 6 weeks ago by kvas

A commit referencing this issue has landed:
Issue 7334 - Remove handling of "Fixes XXXX - ..." commit messages

(unfortunately with a wrong commit message).

comment:5 Changed 6 weeks ago by kvas

  • Resolution set to fixed
  • Status changed from reviewing to closed
Note: See TracTickets for help on using tickets.