Opened on 03/07/2019 at 11:29:04 PM

Closed on 05/14/2019 at 10:54:34 AM

#7344 closed change (fixed)

Remove handling of "Fixes XXXX - ..." commit messages

Reported by: sebastian Assignee: kvas
Priority: P3 Milestone:
Module: Sitescripts Keywords:
Cc: kvas, rhowell Blocked By:
Blocking: Platform: Unknown / Cross platform
Ready: yes Confidential: no
Tester: Unknown Verified working: no
Review URL(s):



With #3681 we added support for commit messages like "Fixes XXXX - ..." which would cause the commit to be referenced in the respective issue on Trac, and the issue to be closed if set up accordingly (which it never was). However, since it was never was set up to actually close the issue, it was rarely used to reference issues on Trac, but it's now conflicting with the notation used to reference issues on GitLab, potentially causing comments about unrelated commits being posted to old issues on Trac.

What to change

Revert the changes implemented in #3681.

Attachments (0)

Change History (5)

comment:1 Changed on 04/17/2019 at 05:39:00 PM by kvas

  • Owner set to kvas

comment:2 Changed on 04/17/2019 at 05:39:16 PM by kvas

  • Priority changed from Unknown to P3
  • Ready set

comment:3 Changed on 04/18/2019 at 04:05:36 PM by kvas

  • Review URL(s) modified (diff)
  • Status changed from new to reviewing

comment:4 Changed on 05/14/2019 at 10:52:04 AM by kvas

A commit referencing this issue has landed:
Issue 7334 - Remove handling of "Fixes XXXX - ..." commit messages

(unfortunately with a wrong commit message).

comment:5 Changed on 05/14/2019 at 10:54:34 AM by kvas

  • Resolution set to fixed
  • Status changed from reviewing to closed

Add Comment

Modify Ticket

Change Properties
as closed .
The resolution will be deleted. Next status will be 'reopened'.
to The owner will be changed from kvas.
Note: See TracTickets for help on using tickets.