Opened 6 months ago

Closed 5 months ago

Last modified 2 months ago

#7345 closed change (fixed)

Use promises for extension API calls in UI (release-2018-5)

Reported by: greiner Assignee: greiner
Priority: P3 Milestone:
Module: User-Interface Keywords:
Cc: Blocked By:
Blocking: #6936 Platform: Unknown / Cross platform
Ready: yes Confidential: no
Tester: Unknown Verified working: yes
Review URL(s):

https://gitlab.com/eyeo/adblockplus/abpui/adblockplusui/merge_requests/243

Description (last modified by greiner)

Background

See ui#352

What to change

See ui#352

Hints for testers

The following parts of the UI should keep working as expected and without errors:

Block element dialog

  • Valid custom filters get added
  • Error message(s) shown when attempting to add invalid custom filter(s)

Bubble UI

  • Domain of active tab shown

Desktop options page

  • The following options are accurately initialized:
    • Checkboxes in Customizations section
    • Custom filters
    • Whitelisted websites
    • Acceptable Ads checkboxes
    • Filter lists (also considering the "additional_subscriptions" setting)
  • Warning message shown when if both EasyPrivacy and Acceptable Ads are enabled, except if user has dismissed it already

Change History (7)

comment:1 Changed 6 months ago by greiner

  • Owner set to greiner
  • Priority changed from Unknown to P3
  • Ready set

comment:2 Changed 6 months ago by greiner

  • Review URL(s) modified (diff)
  • Status changed from new to reviewing

comment:3 Changed 6 months ago by greiner

  • Description modified (diff)

Added hints for testers.

comment:4 Changed 5 months ago by greiner

  • Resolution set to fixed
  • Status changed from reviewing to closed

comment:5 Changed 3 months ago by greiner

  • Blocking 6936 added

comment:6 Changed 3 months ago by abpbot

A commit referencing this issue has landed:
Issue 7345 - Use the extension Promise API in release-2018-5

comment:7 Changed 2 months ago by ukacar

  • Verified working set
Note: See TracTickets for help on using tickets.