Opened 6 weeks ago

Last modified 6 weeks ago

#7347 new defect

Notification animations error on Edge

Reported by: Ross Assignee:
Priority: Unknown Milestone:
Module: Unknown Keywords:
Cc: sebastian, kzar, geo Blocked By:
Blocking: Platform: Edge
Ready: no Confidential: no
Tester: Unknown Verified working: no
Review URL(s):

Description (last modified by Ross)

Environment

ABP 0.9.13.2261
Edge 44.17763.1.0 / Windows 10

NOT a regression compared to 0.9.13 Edge release.

How to reproduce

  1. Serve notification file below.
  2. Install ABP.
  3. Inspect the ABP popup, in the console run:

browser.runtime.sendMessage({type: "prefs.set", key: "notificationurl", value: "http://urlto.the/notification.json"})

  1. Wait 60s until you see notification has been requested.

Test notification

{
  "notifications": [
    {
      "id": "information_onelink",
      "severity": "information",
      "links": [
        "adblock_browser_promotion_0"
      ],
      "title": {
        "en-US": "Test Information Notification",
        "de": "DE Test Information Notification"
      },
      "message": {
        "en-US": "This is a <a>test</a> information notification.",
        "de": "DE This is a <a>test</a> information notification."
      }
    }
  ],
  "version": "201810011538"
}

Observed behaviour

The follow error appears in the console, while attempting to animate the notification:

SCRIPT5022: SCRIPT5022: Error: Invalid value for argument 1. Property 'imageData': Unexpected property, Property 'path': Property is required.
adblockplus.js (11092,13)

3360: Error: Invalid value for argument 1. Property 'imageData': Unexpected property, Property 'path': Property is required.

Expected behaviour

The error not to be logged to the console and icon animations to work as expected. The information notification should animate a ?, the critical notification should animate a !.

Change History (2)

comment:1 Changed 6 weeks ago by Ross

  • Description modified (diff)

comment:2 Changed 6 weeks ago by sebastian

Is this a duplicate of #5746?

Note: See TracTickets for help on using tickets.