Opened on 03/08/2019 at 01:28:54 PM

Closed on 05/28/2019 at 02:17:32 PM

Last modified on 10/08/2019 at 06:07:39 PM

#7347 closed defect (fixed)

Notification animations error on Edge

Reported by: Ross Assignee: geo
Priority: P3 Milestone: Adblock-Plus-for-Chrome-Opera-Firefox-next
Module: Unknown Keywords:
Cc: sebastian, kzar, geo Blocked By:
Blocking: Platform: Edge
Ready: yes Confidential: no
Tester: Ross Verified working: yes
Review URL(s):

Description (last modified by geo)


Edge 44.17763.1.0 / Windows 10

NOT a regression compared to 0.9.13 Edge release.

How to reproduce

  1. Serve notification file below.
  2. Install ABP.
  3. Inspect the ABP popup, in the console run:

browser.runtime.sendMessage({type: "prefs.set", key: "notificationurl", value: "http://urlto.the/notification.json"})

  1. Wait 60s until you see notification has been requested.

Test notification

  "notifications": [
      "id": "information_onelink",
      "severity": "information",
      "links": [
      "title": {
        "en-US": "Test Information Notification",
        "de": "DE Test Information Notification"
      "message": {
        "en-US": "This is a <a>test</a> information notification.",
        "de": "DE This is a <a>test</a> information notification."
  "version": "201810011538"

Observed behaviour

The follow error appears in the console, while attempting to animate the notification:

SCRIPT5022: SCRIPT5022: Error: Invalid value for argument 1. Property 'imageData': Unexpected property, Property 'path': Property is required.
adblockplus.js (11092,13)

3360: Error: Invalid value for argument 1. Property 'imageData': Unexpected property, Property 'path': Property is required.

Expected behaviour

The error not to be logged to the console and icon animations to work as expected. The information notification should animate a ?, the critical notification should animate a !.

Hints for testers

Due to API limitations, we can't have the same nice animation as with the other browsers, instead we just toggle between icons.

Attachments (0)

Change History (12)

comment:1 Changed on 03/08/2019 at 01:29:51 PM by Ross

  • Description modified (diff)

comment:2 Changed on 03/09/2019 at 12:53:28 AM by sebastian

Is this a duplicate of #5746?

comment:3 follow-up: Changed on 05/22/2019 at 04:11:57 PM by geo

Edge doesn't support imageData. A workaround would be to toggle between the normal icon and the notification icon, skipping the fade effect.

Also regarding 5746 I don't think that this ticket is a duplicate, I had some issues seeing the notifications a few times, but I'm using a different setup and I think that was the problem.

comment:4 Changed on 05/22/2019 at 08:38:42 PM by sebastian

That makes sense. The suggested workaround sounds reasonable to me.

comment:5 Changed on 05/22/2019 at 08:39:01 PM by sebastian

  • Priority changed from Unknown to P3
  • Ready set

comment:6 in reply to: ↑ 3 ; follow-up: Changed on 05/23/2019 at 10:34:50 AM by kzar

Replying to geo:

Edge doesn't support imageData.

What about the new Chromium-based Edge?

comment:7 in reply to: ↑ 6 Changed on 05/23/2019 at 11:01:31 AM by Ross

Replying to kzar:

Replying to geo:

Edge doesn't support imageData.

What about the new Chromium-based Edge?

The icon animations work as expected (just like Chrome) as far as I can tell in / Edge Chromium.

comment:8 Changed on 05/23/2019 at 05:00:29 PM by geo

  • Owner set to geo
  • Review URL(s) modified (diff)

comment:9 Changed on 05/28/2019 at 02:07:54 PM by abpbot

comment:10 Changed on 05/28/2019 at 02:17:32 PM by geo

  • Description modified (diff)
  • Milestone set to Adblock-Plus-for-Chrome-Opera-Firefox-next
  • Resolution set to fixed
  • Status changed from new to closed

comment:11 Changed on 07/22/2019 at 07:31:46 AM by Ross

  • Tester changed from Unknown to Ross
  • Verified working set

Fixed. Notification animations work on all platforms.

Microsoft Edge 44.17763.1.0 / Windows 10 1809

Chrome 49.0.2623.75 / Windows 10 1809
Chrome 75.0.3770.142 / Windows 10 1809
Opera 36.0.2130.65 / Windows 10 1809
Opera 62.0.3331.72 / Windows 10 1809
Firefox 51.0 / Windows 10 1809
Firefox 68.0 / Windows 10 1809

comment:12 Changed on 09/13/2019 at 11:21:05 AM by booms1


Last edited on 10/08/2019 at 06:07:39 PM by kzar

Add Comment

Modify Ticket

Change Properties
as closed .
The resolution will be deleted. Next status will be 'reopened'.
to The owner will be changed from geo.
Note: See TracTickets for help on using tickets.