Changes between Initial Version and Version 1 of Ticket #7350


Ignore:
Timestamp:
03/12/2019 04:29:56 PM (2 months ago)
Author:
greiner
Comment:

I agree that we should update adblockplusui/background.js accordingly but I'm not sure why we would need to wait for #7271. As you mentioned, Page.prototype.sendMessage is only being used in our mock and there we're not using the one provided by adblockpluschrome but our own implementation (see adblockplusui/ext/common.js).

Therefore I'd suggest removing that dependency.

Legend:

Unmodified
Added
Removed
Modified
  • Ticket #7350 – Description

    initial v1  
    11=== Background === 
    2 With #7271 we're getting rid of `Page.prototype.sendMessage` and calling `browser.runtime.sendMessage` directly. Once we've done that, we can get rid of the `Page.prototype.sendMessage` stub from adblockplusui/background.js. 
     2With #7271 we're getting rid of `Page.prototype.sendMessage` and calling `browser.tabs.sendMessage` directly. Once we've done that, we can get rid of the `Page.prototype.sendMessage` stub from adblockplusui/background.js. 
    33 
    44=== What to change ===