Changes between Version 1 and Version 3 of Ticket #7350


Ignore:
Timestamp:
03/12/2019 05:45:57 PM (8 months ago)
Author:
greiner
Comment:

Thanks.

Legend:

Unmodified
Added
Removed
Modified
  • Ticket #7350

    • Property Priority changed from Unknown to P3
    • Property Ready set
    • Property Blocked By changed from 7271 to
  • Ticket #7350 – Description

    v1 v3  
    11=== Background === 
    2 With #7271 we're getting rid of `Page.prototype.sendMessage` and calling `browser.tabs.sendMessage` directly. Once we've done that, we can get rid of the `Page.prototype.sendMessage` stub from adblockplusui/background.js. 
     2With #7271 we're getting rid of `Page.prototype.sendMessage` and calling `browser.tabs.sendMessage` directly. Therefore we can get rid of the `Page.prototype.sendMessage` stub from adblockplusui/background.js. 
    33 
    44=== What to change === 
    5 Remove `Page.prototype.sendMessage` from the stub code. 
     5- Remove `Page.prototype.sendMessage` from ext/common.js 
     6- Remove usage of `Page.prototype.sendMessage` in `ext.devtools.onCreated` listener in background.js 
     7 
     8See also [https://gitlab.com/eyeo/adblockplus/abpui/adblockplusui/issues/357 ui#357]