Opened 17 months ago

Last modified 11 months ago

#7350 closed change

Remove Page.prototype.sendMessage from stub code — at Version 3

Reported by: kzar Assignee:
Priority: P3 Milestone:
Module: User-Interface Keywords:
Cc: greiner, sebastian Blocked By:
Blocking: Platform: Unknown / Cross platform
Ready: yes Confidential: no
Tester: Unknown Verified working: no
Review URL(s):

Description (last modified by greiner)


With #7271 we're getting rid of Page.prototype.sendMessage and calling browser.tabs.sendMessage directly. Therefore we can get rid of the Page.prototype.sendMessage stub from adblockplusui/background.js.

What to change

  • Remove Page.prototype.sendMessage from ext/common.js
  • Remove usage of Page.prototype.sendMessage in ext.devtools.onCreated listener in background.js

See also ui#357

Change History (3)

comment:1 Changed 17 months ago by greiner

  • Description modified (diff)

I agree that we should update adblockplusui/background.js accordingly but I'm not sure why we would need to wait for #7271. As you mentioned, Page.prototype.sendMessage is only being used in our mock and there we're not using the one provided by adblockpluschrome but our own implementation (see adblockplusui/ext/common.js).

Therefore I'd suggest removing that dependency.

comment:2 Changed 17 months ago by kzar

  • Blocked By 7271 removed

...Therefore I'd suggest removing that dependency.

Sounds good to me! Done.

comment:3 Changed 17 months ago by greiner

  • Description modified (diff)
  • Priority changed from Unknown to P3
  • Ready set


Note: See TracTickets for help on using tickets.