Opened 9 months ago

Closed 9 months ago

Last modified 4 months ago

#7354 closed defect (fixed)

Devtools panel doesn't respond when first custom filter is added

Reported by: jsonesen Assignee: jsonesen
Priority: P1 Milestone: Adblock-Plus-3.5-for-Chrome-Opera-Firefox
Module: Platform Keywords:
Cc: sebastian, kzar, mjethani Blocked By:
Blocking: Platform: Unknown / Cross platform
Ready: yes Confidential: no
Tester: Ross Verified working: yes
Review URL(s):

https://gitlab.com/eyeo/adblockplus/adblockpluschrome/merge_requests/44

Description (last modified by sebastian)

Steps to reproduce

Right after installing Adblock Plus, before any custom filter ever has been added:

  1. Go to any website (e.g. https://google.com/)
  2. Open the devtools
  3. Switch to the "Adblock Plus" tab
  4. Reload the page
  5. Try to add a filter through the dev tools panel for any request

Observed behaviour

Nothing happens, and the following error is logged to the background page:

Error in event handler: TypeError: subscription.searchfilter is not a function
    at filter (chrome-extension://nlohjgnkebefjephgiamhedijajoblie/lib/adblockplus.js:10189:53)
    at updateFilters (chrome-extension://nlohjgnkebefjephgiamhedijajoblie/lib/adblockplus.js:10210:14)
    at onSubscriptionAdded (chrome-extension://nlohjgnkebefjephgiamhedijajoblie/lib/adblockplus.js:10262:5)
    at EventEmitter.emit (chrome-extension://nlohjgnkebefjephgiamhedijajoblie/lib/adblockplus.js:4902:9)
    at FilterStorage.addSubscription (chrome-extension://nlohjgnkebefjephgiamhedijajoblie/lib/adblockplus.js:3742:20)
    at FilterStorage.addFilter (chrome-extension://nlohjgnkebefjephgiamhedijajoblie/lib/adblockplus.js:3811:12)
    at port.on (chrome-extension://nlohjgnkebefjephgiamhedijajoblie/lib/adblockplus.js:13297:21)
    at Port._onMessage (chrome-extension://nlohjgnkebefjephgiamhedijajoblie/lib/adblockplus.js:4512:22)
    at ext._EventTarget._dispatch (chrome-extension://nlohjgnkebefjephgiamhedijajoblie/ext/common.js:41:22)
    at browser.runtime.onMessage.addListener (chrome-extension://nlohjgnkebefjephgiamhedijajoblie/ext/background.js:534:26)

Expected behaviour

A filter for the selected request should be added, and show imediatelly in the devtools panel. No error should be logged to the background page.

Notes

This is a regression introduced with #7054

Change History (7)

comment:1 Changed 9 months ago by jsonesen

  • Owner set to jsonesen
  • Review URL(s) modified (diff)

comment:2 Changed 9 months ago by jsonesen

  • Cc sebastian added; snoack removed

comment:3 Changed 9 months ago by abpbot

A commit referencing this issue has landed:
Issue 7354 - Fix typo in lib/devtools.js

comment:4 Changed 9 months ago by abpbot

A commit referencing this issue has landed:
Issue 7354 - Fix typo in lib/devtools.js

comment:5 Changed 9 months ago by sebastian

  • Component changed from Unknown to Platform
  • Description modified (diff)
  • Milestone set to Adblock-Plus-3.5-for-Chrome-Opera-Firefox
  • Priority changed from Unknown to P1
  • Ready set
  • Resolution set to fixed
  • Status changed from new to closed
  • Summary changed from Typo in lib/devtools.js to Devtools panel doesn't respond when first custom filter is added
Last edited 9 months ago by sebastian (previous) (diff)

comment:6 Changed 9 months ago by Ross

Fixed in Chrome.

ABP 3.5.0.2270
Chrome 73.0.3683.75

comment:7 Changed 4 months ago by Ross

  • Tester changed from Unknown to Ross
  • Verified working set

Fixed.

ABP 0.9.15.2339
Microsoft Edge 44.17763.1.0 / Windows 10 1809

ABP 3.5.2.2340
Chrome 49.0.2623.75 / Windows 10 1809
Chrome 75.0.3770.142 / Windows 10 1809
Opera 36.0.2130.65 / Windows 10 1809
Opera 62.0.3331.72 / Windows 10 1809
Firefox 51.0 / Windows 10 1809
Firefox 68.0 / Windows 10 1809
Firefox Mobile 68.0 / Android 7.2.2

Note: See TracTickets for help on using tickets.