Changes between Version 19 and Version 21 of Ticket #7360


Ignore:
Timestamp:
05/24/2019 01:48:30 AM (7 months ago)
Author:
mjethani
Comment:

Legend:

Unmodified
Added
Removed
Modified
  • Ticket #7360

    • Property Status changed from reviewing to closed
    • Property Resolution changed from to fixed
    • Property Summary changed from Provide interface to access contents of subscriptions.xml to Provide interface to access contents of subscriptions.json
  • Ticket #7360 – Description

    v19 v21  
    33 
    44While we could share that code across adblockplusui or even adblockpluschrome, this seems to be something that's relevant for anyone who has Core as a dependency. Also, discouraging non-Core code from directly accessing subscriptions.xml would allow Core to assert more control over how it's being used. 
     5 
     6=== Further information === 
     7Currently implemented at: 
     8- [https://hg.adblockplus.org/adblockpluschrome/file/535862e942ed/lib/subscriptionInit.js#l224 adblockpluschrome/subscriptionInit.js] 
     9- [https://hg.adblockplus.org/adblockplusui/file/78fd3c96c712/js/desktop-options.js#l528 adblockplusui/js/desktop-options.js] 
     10- [https://hg.adblockplus.org/adblockplusui/file/78fd3c96c712/mobile-options.js#l99 adblockplusui/mobile-options.js] 
    511 
    612=== What to change === 
     
    1117Also add a `test/recommendations.js`. 
    1218 
    13 === Further information === 
    14 Currently implemented at: 
    15 - [https://hg.adblockplus.org/adblockpluschrome/file/535862e942ed/lib/subscriptionInit.js#l224 adblockpluschrome/subscriptionInit.js] 
    16 - [https://hg.adblockplus.org/adblockplusui/file/78fd3c96c712/js/desktop-options.js#l528 adblockplusui/js/desktop-options.js] 
    17 - [https://hg.adblockplus.org/adblockplusui/file/78fd3c96c712/mobile-options.js#l99 adblockplusui/mobile-options.js] 
     19=== Hints for testers === 
     20Please see the relevant dependency update ticket for adblockpluschrome (Platform).