Changes between Version 21 and Version 22 of Ticket #7360


Ignore:
Timestamp:
05/24/2019 01:50:56 AM (8 weeks ago)
Author:
mjethani
Comment:

Legend:

Unmodified
Added
Removed
Modified
  • Ticket #7360 – Description

    v21 v22  
    11=== Background === 
    2 We're fetching, parsing and interpreting the contents of subscriptions.xml in various places throughout our code (adblockpluschrome/subscriptionInit.js, adblockplusui/js/desktop-options.js, adblockplusui/mobile-options.js) and with [https://gitlab.com/eyeo/adblockplus/abpui/adblockplusui/issues/9 ui#9], we'd do that again. 
     2We're fetching, parsing and interpreting the contents of `subscriptions.json` (previously `subscriptions.xml`) in various places throughout our code (adblockpluschrome/subscriptionInit.js, adblockplusui/js/desktop-options.js, adblockplusui/mobile-options.js) and with [https://gitlab.com/eyeo/adblockplus/abpui/adblockplusui/issues/9 ui#9], we'd do that again. 
    33 
    4 While we could share that code across adblockplusui or even adblockpluschrome, this seems to be something that's relevant for anyone who has Core as a dependency. Also, discouraging non-Core code from directly accessing subscriptions.xml would allow Core to assert more control over how it's being used. 
     4While we could share that code across adblockplusui or even adblockpluschrome, this seems to be something that's relevant for anyone who has Core as a dependency. Also, discouraging non-Core code from directly accessing `subscriptions.json` would allow Core to assert more control over how it's being used. 
    55 
    66=== Further information === 
     
    1111 
    1212=== What to change === 
    13 Expose API for accessing information contained within subscriptions.xml from outside Core 
     13Expose API for accessing information contained within `subscriptions.json` from outside Core 
    1414 
    1515Introduce a new `*recommendations()` generator function in a new file `lib/recommendations.js` that yields `Recommendation` objects based on `data/subscriptions.json`.