Opened 7 months ago

Closed 7 months ago

Last modified 3 months ago

#7374 closed change (fixed)

Rename Snippets to snippets

Reported by: mjethani Assignee: mjethani
Priority: P3 Milestone:
Module: Core Keywords:
Cc: Blocked By:
Blocking: Platform: Unknown / Cross platform
Ready: yes Confidential: no
Tester: Unknown Verified working: yes
Review URL(s):

https://gitlab.com/eyeo/adblockplus/adblockpluscore/merge_requests/30

Description (last modified by mjethani)

Background

See #6891 for background.

What to change

In lib/snippets.js, rename Snippets to snippets.

Integration notes

In adblockpluschrome, in lib/contentFiltering.js, rename Snippets to snippets.

Hints for testers

Just make sure that snippet filters are working as expected. Add a filter example.com#$#log Hello, go to example.com, and see that it logs Hello in the console.

Change History (6)

comment:1 Changed 7 months ago by mjethani

  • Description modified (diff)

comment:2 Changed 7 months ago by mjethani

  • Owner set to mjethani

comment:3 Changed 7 months ago by mjethani

  • Review URL(s) modified (diff)
  • Status changed from new to reviewing

comment:4 Changed 7 months ago by abpbot

A commit referencing this issue has landed:
Issue 7374 - Rename Snippets to snippets

comment:5 Changed 7 months ago by mjethani

  • Description modified (diff)
  • Ready set
  • Resolution set to fixed
  • Status changed from reviewing to closed
  • Summary changed from Properly distinguish objects from classes (part 2) to Rename Snippets to snippets

comment:6 Changed 3 months ago by ukacar

  • Verified working set
Note: See TracTickets for help on using tickets.