Opened 7 months ago

Closed 7 months ago

Last modified 3 months ago

#7377 closed change (fixed)

Rename Synchronizer to synchronizer

Reported by: mjethani Assignee: mjethani
Priority: P2 Milestone:
Module: Core Keywords:
Cc: greiner Blocked By:
Blocking: Platform: Unknown / Cross platform
Ready: yes Confidential: no
Tester: Ross Verified working: yes
Review URL(s):

https://gitlab.com/eyeo/adblockplus/adblockpluscore/merge_requests/33

Description (last modified by mjethani)

Background

In #6891 we made the naming consistent in a few files, but somehow we forgot to lower-case exports.Synchronizer in lib/synchronizer.js.

What to change

Rename exports.Synchronizer to exports.synchronizer in lib/synchronizer.js.

Integration notes

In adblockpluschrome, in lib/subscriptionInit.js, rename Synchronizer to synchronizer.

In adblockplusui, in both background.js and messageResponder.js, rename Synchronizer to synchronizer.

Hints for testers

This change does not affect any of the code in Core, but please check the dependency update ticket in Platform for hints.

Change History (8)

comment:1 Changed 7 months ago by mjethani

  • Ready set
  • Review URL(s) modified (diff)
  • Status changed from new to reviewing

comment:2 Changed 7 months ago by abpbot

A commit referencing this issue has landed:
Issue 7377 - Rename Synchronizer to synchronizer

comment:3 Changed 7 months ago by mjethani

  • Owner set to mjethani

comment:4 Changed 7 months ago by mjethani

  • Description modified (diff)
  • Resolution set to fixed
  • Status changed from reviewing to closed

comment:5 Changed 7 months ago by mjethani

  • Description modified (diff)

comment:6 Changed 6 months ago by greiner

  • Cc greiner added

comment:7 Changed 3 months ago by Ross

Done. Does not look to have caused any regressions.

ABP 0.9.15.2340
Microsoft Edge 44.17763.1.0 / Windows 10 1809

ABP 3.5.2.2340
Chrome 49.0.2623.75 / Windows 10 1809
Chrome 75.0.3770.142 / Windows 10 1809
Opera 36.0.2130.65 / Windows 10 1809
Opera 62.0.3331.72 / Windows 10 1809
Firefox 51.0 / Windows 10 1809
Firefox 68.0 / Windows 10 1809
Firefox Mobile 68.0 / Android 7.2.2

comment:8 Changed 3 months ago by Ross

  • Tester changed from Unknown to Ross
  • Verified working set
Note: See TracTickets for help on using tickets.