Opened 5 months ago

Closed 5 months ago

Last modified 4 weeks ago

#7380 closed change (fixed)

Remove references to onShutdown

Reported by: mjethani Assignee: mjethani
Priority: P3 Milestone:
Module: Core Keywords:
Cc: sergz, sebastian Blocked By:
Blocking: #5702 Platform: Unknown / Cross platform
Ready: yes Confidential: no
Tester: Ross Verified working: yes
Review URL(s):

https://gitlab.com/eyeo/adblockplus/adblockpluscore/merge_requests/35

Description (last modified by mjethani)

Background

The onShutdown global appears to be based on some legacy Gecko APIs (#5702). Its purpose mainly is to stop the scheduled syncing of filter lists. In the WebExt version of Adblock Plus, it appears unnecessary and is in fact a no-op.

Along with this global, the cancel method of the Downloader object can also be removed.

What to change

Remove all references to onShutdown global. Also remove the cancel method of the Downloader object as it would no longer be useful.

Integration notes

In adblockpluschrome, in lib/compat.js, remove the onShutdown object.

Hints for testers

Same as #7376.

Change History (8)

comment:1 Changed 5 months ago by mjethani

  • Description modified (diff)
  • Owner set to mjethani
  • Priority changed from Unknown to P3
  • Ready set

comment:2 Changed 5 months ago by mjethani

  • Cc sergz sebastian added
  • Component changed from Unknown to Core

comment:3 Changed 5 months ago by mjethani

  • Blocking 5702 added
  • Review URL(s) modified (diff)
  • Status changed from new to reviewing

comment:4 Changed 5 months ago by mjethani

@sergz I hope libadblockplus does not rely on the global onShutdown object in any way, but if it does then let me know.

comment:5 Changed 5 months ago by abpbot

A commit referencing this issue has landed:
Issue 7380 - Remove references to onShutdown

comment:6 Changed 5 months ago by sebastian

  • Resolution set to fixed
  • Status changed from reviewing to closed

comment:7 Changed 5 months ago by mjethani

  • Description modified (diff)

comment:8 Changed 4 weeks ago by Ross

  • Tester changed from Unknown to Ross
  • Verified working set

Done. Working as described.

ABP 0.9.15.2340
Microsoft Edge 44.17763.1.0 / Windows 10 1809

ABP 3.5.2.2340
Chrome 49.0.2623.75 / Windows 10 1809
Chrome 75.0.3770.142 / Windows 10 1809
Opera 36.0.2130.65 / Windows 10 1809
Opera 62.0.3331.72 / Windows 10 1809
Firefox 51.0 / Windows 10 1809
Firefox 68.0 / Windows 10 1809
Firefox Mobile 68.0 / Android 7.2.2

Note: See TracTickets for help on using tickets.