Changes between Initial Version and Version 1 of Ticket #7380


Ignore:
Timestamp:
03/19/2019 10:32:42 AM (10 months ago)
Author:
mjethani
Comment:

Legend:

Unmodified
Added
Removed
Modified
  • Ticket #7380

    • Property Owner set to mjethani
    • Property Priority changed from Unknown to P3
    • Property Ready set
  • Ticket #7380 – Description

    initial v1  
    11=== Background === 
    2 Replace this text with your reasoning that lead to wanting the change. 
     2The `onShutdown` global appears to be based on some legacy Gecko APIs (#5702). Its purpose mainly is to stop the scheduled syncing of filter lists. In the WebExt version of Adblock Plus, it appears unnecessary and is in fact a no-op. 
     3 
     4Along with this global, the `cancel` method of the `Downloader` object can also be removed. 
    35 
    46=== What to change === 
    5 Replace this text with the detailed description of what exactly shall be changed/added and where. 
     7Remove all references to `onShutdown` global. Also remove the `cancel` method of the `Downloader` object as it would no longer be useful. 
     8 
     9=== Integration notes === 
     10In adblockpluschrome, in `lib/compat.js`, remove the `onShutdown` object.