Opened 13 months ago

Closed 7 months ago

#7392 closed change (rejected)

Write test for the case when a subscription download is terminated midway

Reported by: mjethani Assignee:
Priority: Unknown Milestone:
Module: Core Keywords: closed-in-favor-of-gitlab
Cc: hfiguiere, jsonesen, kzar Blocked By: #7381
Blocking: Platform: Unknown / Cross platform
Ready: no Confidential: no
Tester: Unknown Verified working: no
Review URL(s):



With #7381 we are moving to the Fetch API. In Fetch, the text of the response is returned via a text() method that returns a promise that resolves with the response text. If the download is terminated midway, the promise will be rejected.

But our tests are written for XMLHttpRequest semantics (see registerHandler and its usage). We need to bring in promises here and update all the tests accordingly.

What to change

To be determined.

Change History (4)

comment:1 Changed 13 months ago by mjethani

  • Cc hfiguiere jsonesen kzar added

comment:2 Changed 12 months ago by kzar

  • Blocked By 7381 added

comment:3 Changed 12 months ago by mjethani

We also need to add a test for when the subscription URL is invalid

comment:4 Changed 7 months ago by sebastian

  • Keywords closed-in-favor-of-gitlab added
  • Resolution set to rejected
  • Status changed from new to closed

Sorry, but we switched to GitLab. If this issue is still relevant, please file it again in the new issue tracker.

Note: See TracTickets for help on using tickets.