Opened 9 months ago

Closed 8 months ago

Last modified 2 months ago

#7401 closed change (fixed)

Adapt code to work with removed Subscription.prototype.filters

Reported by: greiner Assignee: jsonesen
Priority: P3 Milestone:
Module: User-Interface Keywords:
Cc: jsonesen Blocked By:
Blocking: #7308 Platform: Unknown / Cross platform
Ready: yes Confidential: no
Tester: Unknown Verified working: yes
Review URL(s):

https://gitlab.com/eyeo/adblockplus/abpui/adblockplusui/merge_requests/249
https://gitlab.com/eyeo/adblockplus/abpui/adblockpluschrome/merge_requests/23

Description

Background

See ui#366.

What to change

See ui#366.

Change History (9)

comment:1 Changed 8 months ago by jsonesen

  • Review URL(s) modified (diff)
  • Status changed from new to reviewing

comment:2 Changed 8 months ago by greiner

  • Owner set to jsonesen

comment:3 Changed 8 months ago by greiner

  • Resolution set to fixed
  • Status changed from reviewing to closed

comment:4 Changed 8 months ago by jsonesen

Will a trac issue for the next release be made as well so we can block the 7308 ticket, since it is still not ready

comment:5 Changed 8 months ago by greiner

We're going to update both Core and UI dependencies simultaneously in #7308 because they depend on each other. Therefore #7308 is already the ticket for the next release. We merely need to add the commit hash to it and it should be ready to go.

comment:6 Changed 8 months ago by greiner

  • Review URL(s) modified (diff)

Added another change that makes sure this change also works with our UI Nightlies so that we can test it.

comment:8 Changed 8 months ago by yoyo888

Version 1, edited 8 months ago by greiner (previous) (next) (diff)

comment:9 Changed 5 months ago by ukacar

  • Verified working set
Note: See TracTickets for help on using tickets.