Opened 6 months ago

Closed 3 weeks ago

#7403 closed defect (rejected)

:-abp-properties() does not work when using a compound selector to select an element whose styles are specified also using a compound selector containing a different first simple selector

Reported by: mjethani Assignee:
Priority: P3 Milestone:
Module: Core Keywords: closed-in-favor-of-gitlab
Cc: amr, agiammarchi, hfiguiere Blocked By:
Blocking: Platform: Unknown / Cross platform
Ready: no Confidential: no
Tester: Unknown Verified working: no
Review URL(s):

Description

Environment

Adblock Plus 3.5
Google Chrome 75 (Canary)
macOS 10.12

How to reproduce

Add the filter #?#body span:-abp-properties(color: red)

Then load the following document:

<html>
  <head>
    <style>
      div .ad {
        color: red;
      }
    </style>
  </head>
  <body>
    <div>
      <span class="ad">Ad</span>
    </div>
  </body>
</html>

Observed behaviour

The text "Ad" is not hidden.

Expected behaviour

The text "Ad" should be hidden.

Notes

qualifySelector() qualifies div .ad with prefix body span as div body span.ad. If the filter is changed to simply #?#span:-abp-properties(color: red), it works.

Related issues

#7402

Change History (2)

comment:1 Changed 6 months ago by mjethani

  • Cc amr agiammarchi hfiguiere added

comment:2 Changed 3 weeks ago by sebastian

  • Keywords closed-in-favor-of-gitlab added
  • Resolution set to rejected
  • Status changed from new to closed

Sorry, but we switched to GitLab. If this issue is still relevant, please file it again in the new issue tracker.

Note: See TracTickets for help on using tickets.