Changes between Initial Version and Version 6 of Ticket #7408


Ignore:
Timestamp:
03/26/2019 05:29:56 PM (10 months ago)
Author:
kzar
Comment:

Cool OK, I'll go ahead with that then.

Legend:

Unmodified
Added
Removed
Modified
  • Ticket #7408

    • Property Owner set to kzar
    • Property Summary changed from Replace window.confirm question notification fallback to Remove window.confirm question notification fallback
  • Ticket #7408 – Description

    initial v6  
    33 
    44=== What to change === 
    5 Remove the `confirm` call in `adblockpluschrome/lib/notificationHelper.js` and replace it with something else. For example, perhaps we should resort to showing the notification in the popup window instead? 
     5Remove the clause containing `confirm` in `adblockpluschrome/lib/notificationHelper.js` entirely. 
     6 
     7=== Hints for testers === 
     8We no longer expect notifications of type "question" to be displayed on Edge.