Opened 2 months ago

Closed 5 weeks ago

#7416 closed change (fixed)

Remove string used for window.confirm notifications

Reported by: greiner Assignee: greiner
Priority: P3 Milestone:
Module: User-Interface Keywords:
Cc: Blocked By: #7408
Blocking: #7431 Platform: Unknown / Cross platform
Ready: yes Confidential: no
Tester: Unknown Verified working: no
Review URL(s):

https://gitlab.com/eyeo/adblockplus/abpui/adblockplusui/merge_requests/269

Description

Background

We're removing usage of window.confirm() for notifications (see #7408) so we no longer need the string that's shown in the prompt.

What to change

Remove "notification_with_buttons" translatable string.

Change History (4)

comment:1 Changed 8 weeks ago by greiner

  • Blocking 7431 added

comment:2 Changed 5 weeks ago by greiner

  • Owner set to greiner

comment:3 Changed 5 weeks ago by greiner

  • Review URL(s) modified (diff)
  • Status changed from new to reviewing

comment:4 Changed 5 weeks ago by greiner

  • Resolution set to fixed
  • Status changed from reviewing to closed
Note: See TracTickets for help on using tickets.