Changes between Version 1 and Version 3 of Ticket #7435


Ignore:
Timestamp:
04/05/2019 08:14:17 AM (7 months ago)
Author:
mjethani
Comment:

Legend:

Unmodified
Added
Removed
Modified

  • Ticket #7435

    • Property Cc sebastian greiner added

  • Ticket #7435 – Description

    v1 v3  
    1717 
    1818=== Integration notes === 
    19 [TBD] 
     19The signature of the `matches()` public method of the `RegExpFilter` class has now changed: 
     20 
     21{{{ 
     22-  matches(location, typeMask, docDomain, thirdParty, sitekey) 
     23+  matches(request, typeMask, sitekey) 
     24}}} 
     25 
     26The first argument `request` should of type `URLRequest`, which is exported from `lib/url.js`. 
     27 
     28For example, the following call: 
     29 
     30{{{ 
     31filter.matches("https://example.com/image.png", RegExpFilter.typeMap.IMAGE, 
     32               "example.com", false, null) 
     33}}} 
     34 
     35It should now look like this: 
     36 
     37{{{ 
     38filter.matches(URLRequest.from("https://example.com/image.png", "example.com"), 
     39               RegExpFilter.typeMap.IMAGE, null) 
     40}}} 
     41 
     42The JSDoc for the `URLRequest` class incorrectly [https://hg.adblockplus.org/adblockpluscore/rev/cee47bcf494e#l3.42 marks it as @package]. Please ignore this, it is public, but there may be further changes to it. 
    2043 
    2144=== Hints for testers ===