Changes between Version 6 and Version 7 of Ticket #7435


Ignore:
Timestamp:
04/13/2019 01:13:25 PM (6 months ago)
Author:
mjethani
Comment:

Legend:

Unmodified
Added
Removed
Modified
  • Ticket #7435

    • Property Status changed from reviewing to closed
    • Property Resolution changed from to fixed
  • Ticket #7435 – Description

    v6 v7  
    2424}}} 
    2525 
    26 The first argument `request` should of type `URLRequest`, which is exported from `lib/url.js`. 
     26The first argument `request` should be of type `URLRequest`, which is exported from `lib/url.js`. 
    2727 
    2828For example, the following call: 
     
    4545 
    4646=== Hints for testers === 
    47 [TBD] 
     47This basically covers all kinds of requests, but in particular where a filter is case-insensitive and the URL's case does not match, and where a filter targets third-party requests and the request is ''not'' third-party (or vice versa), those are good areas to focus on. 
     48 
     49For example, add the filters `-foo-` and `-bar-`; then the URLs `https://example.com/example-bar-ad` and `https://example.com/Example-Bar-Ad` should be blocked by the second filter. If the second filter is changed to `-bar-$match-case`, then only the first URL should be blocked. 
     50 
     51Similarly, if the second filter is changed to `-bar-$third-party`, then the URL `https://example.com/Example-Bar-Ad` should be blocked if the request is made from a document loaded from `http://localhost:8080/test.html` but ''not'' if the document is loaded from `https://example.com/test.html`. It should be the opposite if the filter is changed to `-bar-$~third-party`.