Opened 8 months ago

Closed 8 months ago

Last modified 8 months ago

#7445 closed change (rejected)

Implement faster parsing of generic element hiding filters

Reported by: mjethani Assignee: mjethani
Priority: P3 Milestone:
Module: Core Keywords:
Cc: hfiguiere Blocked By:
Blocking: #7000 Platform: Unknown / Cross platform
Ready: yes Confidential: no
Tester: Unknown Verified working: no
Review URL(s):

Description (last modified by mjethani)

Background

The regular expression used to parse content filters is currently /^([^/*|@"!]*?)#([@?$])?#(.+)$/. By this definition, if a filter starts with ##, the rest of the text is always the CSS selector. In EasyList ~20,000 out of ~75,000 lines start with ##.

We can skip the regular expression for this special and very common case.

Resolution

After some investigation, there appears to be no benefit of making this change.

Change History (3)

comment:1 Changed 8 months ago by mjethani

  • Blocking 7000 added

comment:2 Changed 8 months ago by mjethani

  • Description modified (diff)
  • Resolution set to rejected
  • Status changed from new to closed

comment:3 Changed 8 months ago by mjethani

  • Cc hfiguiere added
Note: See TracTickets for help on using tickets.