Opened 8 months ago

Closed 8 months ago

#7461 closed change (fixed)

[CMS] Include source page into warning text for unresolved links

Reported by: kvas Assignee: kvas
Priority: P3 Milestone:
Module: Sitescripts Keywords:
Cc: julian Blocked By:
Blocking: Platform: Unknown / Cross platform
Ready: yes Confidential: no
Tester: Unknown Verified working: no
Review URL(s):

https://codereview.adblockplus.org/30044555/

Description

Background

If a website has broken links, CMS generates a warning like this:

WARNING:root:Link to some-page cannot be resolved

It's great to have a warning but it would be even better if the warning gave information on where to look for the broken links.

What to change

Include the name of the source page (the one that links to a non-existing page) into the text of the warning.

Implementation note: the link is produced by this line. We need to pass the source page into the function and insert it into the warning.

Change History (3)

comment:1 Changed 8 months ago by kvas

  • Review URL(s) modified (diff)
  • Status changed from new to reviewing

comment:2 Changed 8 months ago by abpbot

comment:3 Changed 8 months ago by kvas

  • Resolution set to fixed
  • Status changed from reviewing to closed
Note: See TracTickets for help on using tickets.