Opened 5 weeks ago

Last modified 5 weeks ago

#7467 reviewing change

Migrate rpy to Python 3

Reported by: rhowell Assignee: rhowell
Priority: P3 Milestone:
Module: Sitescripts Keywords:
Cc: kvas, sporz Blocked By:
Blocking: Platform: Unknown / Cross platform
Ready: yes Confidential: no
Tester: Unknown Verified working: no
Review URL(s):

https://codereview.adblockplus.org/30047570/

Description

Background

Python 2 will cease being supported at the start of 2020. We have decided to migrate the code to Python 3 before that date. There also seems to be an issue with string encoding when using the reticulate package in R, and migrating to Python 3 should resolve this.

What to change

Remove strings2utf8() and related tests.

Change History (2)

comment:1 Changed 5 weeks ago by rhowell

  • Review URL(s) modified (diff)
  • Status changed from new to reviewing

comment:2 Changed 5 weeks ago by kvas

  • Priority changed from Unknown to P3
  • Ready set
Note: See TracTickets for help on using tickets.