Opened 6 years ago

Closed 6 years ago

Last modified 6 years ago

#764 closed defect (fixed)

Adblock Warning opt in message isn't triggered

Reported by: arthur Assignee: saroyanm
Priority: P2 Milestone: Adblock-Plus-2.6.4-for-Firefox
Module: Adblock-Plus-for-Firefox Keywords:
Cc: Blocked By:
Blocking: #301 Platform: Firefox
Ready: yes Confidential: no
Tester: Verified working: no
Review URL(s):



Firefox 30
Adblock Plus 2.6.3
Windows 8.1 Pro x64 Update 1

How to reproduce

  1. Create a new Firefox profile
  2. Install Adblock Plus 2.6.3
  3. Go to a site that should trigger the Adblock Warning message like

Observed behaviour

The opt in message for the Adblock Warning Removal List doesn't appear.

Expected behaviour

It should appear when visiting the website.

Change History (6)

comment:1 Changed 6 years ago by saroyanm

  • Owner set to saroyanm

comment:2 Changed 6 years ago by saroyanm

  • Review URL(s) modified (diff)
  • Status changed from new to reviewing

comment:3 Changed 6 years ago by saroyanm

  • Resolution set to fixed
  • Status changed from reviewing to closed

comment:4 Changed 6 years ago by saroyanm

The issue persisted for three month:
Here is the revision that caused the issue:

comment:5 Changed 6 years ago by trev

  • Blocking 301 added

Manvel's investigation shows that this issue is a regression from #301. Apparently, a for loop will allow looping over null whereas a for..of loop won't.

comment:6 Changed 6 years ago by trev

  • Milestone set to Adblock-Plus-for-Firefox-next
Note: See TracTickets for help on using tickets.