Opened 5 years ago

Closed 5 years ago

Last modified 14 months ago

#8 closed change (fixed)

[libadblockplus integration cleanup] Don't hard code AppInfo properties and set the remaining ones: applicationVersion, locale and developmentBuild

Reported by: fhd Assignee: fhd
Priority: P3 Milestone: Adblock-Plus-for-Android-1.3
Module: Adblock-Plus-for-Android Keywords:
Cc: Blocked By:
Blocking: #7 Platform:
Ready: Confidential: no
Tester: Verified working: no
Review URL(s):

Description

Background

See #7

What to change

Don't hard code AppInfo properties and set the remaining ones: applicationVersion, locale and developmentBuild. (http://codereview.adblockplus.org/11172036/diff/1/jni/abpEngine.cpp#newcode154)

Change History (12)

comment:1 Changed 5 years ago by philll

  • Summary changed from Don't hard code AppInfo properties and set the remaining ones: applicationVersion, locale and developmentBuild to [libadblockplus integration cleanup] Don't hard code AppInfo properties and set the remaining ones: applicationVersion, locale and developmentBuild

comment:2 Changed 5 years ago by philll

  • Keywords libadblockplus integration cleanup removed

comment:3 Changed 5 years ago by trev

  • Component changed from Unknown to ABP-Android

comment:4 Changed 5 years ago by philll

  • Owner set to rjeschke
  • Status changed from new to assigned

comment:5 Changed 5 years ago by fhd

  • Reporter changed from philll to fhd

comment:6 Changed 5 years ago by fhd

  • Priority changed from Unknown to P3

comment:7 Changed 5 years ago by fhd

  • Owner rjeschke deleted

comment:8 Changed 5 years ago by fhd

  • Status changed from assigned to accepted

comment:9 Changed 5 years ago by fhd

  • Owner set to fhd
  • Status changed from accepted to assigned

comment:10 Changed 5 years ago by fhd

  • Resolution set to fixed
  • Status changed from assigned to closed

comment:11 Changed 5 years ago by trev

  • Milestone set to Adblock-Plus-for-Android-next

comment:12 Changed 14 months ago by johnson83

Note: See TracTickets for help on using tickets.