Opened on 07/20/2014 at 04:19:59 AM

Closed on 07/20/2014 at 11:11:03 PM

Last modified on 05/20/2015 at 02:22:39 PM

#1088 closed defect (duplicate)

$document, $elemhide and element hiding exceptions don't fully cancel hiding rules

Reported by: Crits Assignee:
Priority: P2 Milestone:
Module: Adblock-Plus-for-Firefox Keywords:
Cc: mapx Blocked By:
Blocking: Platform: Firefox
Ready: no Confidential: no
Tester: Verified working: no
Review URL(s):

Description (last modified by Crits)

Environment

Firefox 30.0 (tested with fresh profile)
Adblock Plus 2.6.3.3849 (only enabled add-on in FF)
No subscription, only one filter : ##.ad_item

How to reproduce

  1. Add one of the following filter:
    @@||myhouseabroad.com^$document
    @@||myhouseabroad.com^$elemhide
    #@#.ad_item
    myhouseabroad.com#@#.ad_item
    
  2. Go to http://www.myhouseabroad.com/en/search/Luxury_Real_Estate.html

Observed behaviour

Display is broken, the "View" and "Save" buttons are too high (see attached file Broken display.jpg)

Expected behaviour

See attached file Normal display.jpg. This normal behaviour can be obtained by either disabling Adblock Plus everywhere or removing ##.ad_item

Note that with ABP enabled with just ##.ad_item and no exception rules, the Real Estate ads are actually completely hidden. Thus, the exception rules have indeed some effect but not the desired one.

The website owner might modify the classes of some of the website elements to circumvent this problem, if it is the case note that the elements whose classes are currently ad_item are located right after <!-- LIST ADS --> in the page source code.

Attachments (2)

Broken display.JPG (36.8 KB) - added by Crits on 07/20/2014 at 04:20:33 AM.
Normal display.JPG (37.7 KB) - added by Crits on 07/20/2014 at 04:20:42 AM.

Download all attachments as: .zip

Change History (8)

Changed on 07/20/2014 at 04:20:33 AM by Crits

Changed on 07/20/2014 at 04:20:42 AM by Crits

comment:1 Changed on 07/20/2014 at 04:38:42 AM by Crits

  • Description modified (diff)

comment:2 Changed on 07/20/2014 at 08:23:35 AM by mapx

  • Cc mapx added
  • Priority changed from Unknown to P2

comment:3 follow-up: Changed on 07/20/2014 at 03:40:50 PM by barbaz

comment:4 in reply to: ↑ 3 Changed on 07/20/2014 at 11:09:44 PM by Crits

Replying to barbaz:

https://issues.adblockplus.org/ticket/521

Well found, reading the comments from arthur and trev it seems it would be fixed by #521

comment:5 Changed on 07/20/2014 at 11:11:03 PM by Crits

  • Resolution set to duplicate
  • Status changed from new to closed

comment:6 Changed on 05/20/2015 at 02:22:39 PM by philll

  • Platform changed from Firefox/Firefox Mobile to Firefox

Made Firefox and Firefox mobile available as seperate platforms.

Add Comment

Modify Ticket

Change Properties
Action
as closed .
The resolution will be deleted. Next status will be 'reopened'.
to The owner will be changed from (none).
 
Note: See TracTickets for help on using tickets.