Opened on 07/21/2014 at 07:24:22 PM

Closed on 09/15/2014 at 10:07:51 AM

Last modified on 05/20/2015 at 02:22:39 PM

#1091 closed change (fixed)

Implement a better templating approach for Element Hiding Helper

Reported by: trev Assignee: trev
Priority: P3 Milestone: Element-Hiding-Helper-1.3.1
Module: Extensions-for-Adblock-Plus Keywords:
Cc: Blocked By:
Blocking: Platform: Firefox
Ready: yes Confidential: no
Tester: Verified working: no
Review URL(s):

​http://codereview.adblockplus.org/5684127030312960/

Description

Background

Currently, Element Hiding Helper will create the element marker by cloning a node from the browser document and inserting it into the content document then. This is quite a hack and not exactly unproblematic either, particularly in the e10s scenario (see ​https://bugzilla.mozilla.org/show_bug.cgi?id=1041071).

What to change

Create the marker in the content document where it is used,

Attachments (0)

Change History (3)

comment:1 Changed on 07/21/2014 at 07:28:43 PM by trev

  • Review URL(s) modified (diff)
  • Status changed from new to reviewing

comment:2 Changed on 09/15/2014 at 10:07:51 AM by trev

  • Milestone set to Element-Hiding-Helper-next
  • Resolution set to fixed
  • Status changed from reviewing to closed

Fixed: ​https://hg.adblockplus.org/elemhidehelper/rev/3142de28cec4

comment:3 Changed on 05/20/2015 at 02:22:39 PM by philll

  • Platform changed from Firefox/Firefox Mobile to Firefox

Made Firefox and Firefox mobile available as seperate platforms.

Add Comment

Modify Ticket

Change Properties
Action
as closed .
The resolution will be deleted. Next status will be 'reopened'.
to The owner will be changed from trev.
Attachments ↑ Description ↑
 
Note: See TracTickets for help on using tickets.