Opened on 07/23/2014 at 11:04:41 AM
Closed on 11/05/2015 at 10:24:18 AM
#1107 closed change (fixed)
Support notifications
| Reported by: | fhd | Assignee: | sergz |
|---|---|---|---|
| Priority: | P3 | Milestone: | |
| Module: | Libadblockplus | Keywords: | |
| Cc: | jobp, fhd | Blocked By: | |
| Blocking: | Platform: | Unknown | |
| Ready: | yes | Confidential: | no |
| Tester: | Unknown | Verified working: | no |
| Review URL(s): |
http://codereview.adblockplus.org/5797488346791936/ |
||
Description (last modified by fhd)
Background
Adblock Plus supports notifications on most platforms. libadblockplus should also support this.
What to change
Regularly download notifications and decide which ones to show. We can either implement this as a function called by the client or as a callback.
Note that the notification download should only happen if clients are actually interested in notifications, similar to how updating works.
Attachments (0)
Change History (13)
comment:1 Changed on 07/23/2014 at 11:06:17 AM by fhd
- Blocking 1108 added
comment:2 Changed on 07/23/2014 at 11:10:00 AM by fhd
- Blocking 1109 added
comment:4 Changed on 01/13/2015 at 11:34:41 AM by jobp
- Blocking 1790 added
comment:5 Changed on 01/13/2015 at 05:55:15 PM by sergz
- Owner set to sergz
comment:6 Changed on 01/19/2015 at 12:56:47 PM by sergz
- Review URL(s) modified (diff)
- Status changed from new to reviewing
comment:7 Changed on 01/19/2015 at 01:09:09 PM by jobp
- Cc jobp added
comment:9 Changed on 01/27/2015 at 11:00:51 AM by sergz
- Cc fhd added
comment:10 Changed on 02/13/2015 at 11:16:53 AM by jobp
- Blocking 1790 removed
comment:11 Changed on 02/18/2015 at 04:49:23 PM by rjeschke
- Blocking 1108 removed
comment:12 Changed on 08/20/2015 at 02:11:45 PM by sergz
- Blocking 1109 removed
comment:13 Changed on 11/05/2015 at 10:24:18 AM by sergz
- Resolution set to fixed
- Status changed from reviewing to closed
- Tester set to Unknown
Note: See
TracTickets for help on using
tickets.
I would like to precise here whether we need question notification listeners in libadblockplus or not.
First of all I guess it could be inconvenient for the libadlockplus client to fiddle around with our listeners and it might be merely an additional work for the client. In addition there is a technical reason, the user does not know and cannot predict the ID of the notification as well as there is no official way to to obtain it (since there is no Notification::GetID).
So, my suggestion is leave it up to the libadblockplus client. Your thoughts?