Opened on 07/23/2014 at 01:28:35 PM
Closed on 11/10/2017 at 11:15:18 AM
#1117 closed defect (rejected)
User able to send an issue report on invalid email
| Reported by: | passbrains | Assignee: | |
|---|---|---|---|
| Priority: | P4 | Milestone: | |
| Module: | Adblock-Plus-for-Firefox | Keywords: | |
| Cc: | mapx | Blocked By: | |
| Blocking: | Platform: | Firefox | |
| Ready: | yes | Confidential: | no |
| Tester: | Verified working: | no | |
| Review URL(s): | |||
Description (last modified by trev)
Adapted from https://www.passbrains.com/dashboard/view-ticket.php?ticket_no=ARE-1
Environment
Windows XP 32bit Firefox English
ABP version 1.8.3.1204
How to reproduce
- Install Adblock 1.8.3.1204 into Firefox 31.0
- Open any website (e.g http://photo.net)
- Click on ABP icon and then on 'Report issue on this page...' label
- Choose the type of reported issue
- Click on Next button two times
- Enter invalid email into Email field (e.g '1')
- Click on Send report button, observe the message "Your report has been saved..."
Observed behaviour
User able to send an issue report on invalid email.
Expected behaviour
User able to send an issue report only on valid email.
Attachments (1)
Change History (7)
Changed on 07/23/2014 at 01:28:38 PM by passbrains
comment:1 Changed on 07/23/2014 at 01:32:15 PM by trev
- Component changed from Unknown to Adblock-Plus-for-Firefox
- Description modified (diff)
- Priority changed from Unknown to P4
- Ready set
comment:2 Changed on 07/23/2014 at 06:58:36 PM by mapx
1.8.3.1204 is the last dev build for chrome
comment:3 Changed on 07/23/2014 at 06:59:25 PM by mapx
- Cc mapx added
comment:4 Changed on 07/24/2014 at 07:57:32 AM by philll
I asked the tester to hand in the correct number.
comment:5 Changed on 05/20/2015 at 02:22:39 PM by philll
- Platform changed from Firefox/Firefox Mobile to Firefox
Made Firefox and Firefox mobile available as seperate platforms.
comment:6 Changed on 11/10/2017 at 11:15:18 AM by trev
- Resolution set to rejected
- Status changed from new to closed
Mass-closing all bugs in Adblock Plus for Firefox module, the codebase of Adblock Plus 3.0 belongs into Platform and User-Interface modules. Old bugs are unlikely to still apply.
Note: See
TracTickets for help on using
tickets.
We aren't too strict about data validation in the issue reporter, that's why we didn't bother validating the email addresses. However, now that the email address is mandatory, it makes sense to have minimal validation here - simply adding type="email" will do. We merely need to ensure that the user cannot continue if the email address is invalid.