Opened on 07/24/2014 at 12:06:07 PM
Closed on 09/11/2014 at 08:45:52 AM
Last modified on 05/20/2015 at 02:22:39 PM
#1133 closed defect (fixed)
Sharing on Twitter and Google doesn't work
| Reported by: | passbrains | Assignee: | greiner |
|---|---|---|---|
| Priority: | P2 | Milestone: | Adblock-Plus-2.6.5-for-Firefox |
| Module: | User-Interface | Keywords: | |
| Cc: | Blocked By: | ||
| Blocking: | Platform: | Firefox | |
| Ready: | yes | Confidential: | no |
| Tester: | Verified working: | no | |
| Review URL(s): | |||
Description (last modified by greiner)
Adapted from https://www.passbrains.com/dashboard/view-ticket.php?ticket_no=AOP-2
Environment
Windows 7 32bit Opera English
ABP version Version 1.8.3.1204
How to reproduce
- Install ABP extension on Opera
- When "Adblock Plus has been installed" page opens click Twitter or Google button
- When "Think Adblock Plus is worth sharing?" window opens observe it and click Twitter icon
Observed behaviour
When click Twitter button on "Adblock Plus has been installed" page, "Think Adblock Plus is worth sharing?" window opens, but clicking Twitter icon here does nothing. Adblock sharing on Twitter and Google doesn't work.
Expected behaviour
Adblock Twitter page should open.
Attachments (2)
Change History (11)
Changed on 07/24/2014 at 12:06:10 PM by passbrains
Changed on 07/24/2014 at 12:06:12 PM by passbrains
comment:1 Changed on 07/24/2014 at 12:06:15 PM by passbrains
comment:2 Changed on 07/24/2014 at 12:12:03 PM by greiner
- Description modified (diff)
Previously, this issue has been taken care of in https://hg.adblockplus.org/adblockplus/rev/f37b9e53d4e7 and https://hg.adblockplus.org/adblockplus/rev/7d3832ef378d due to "Remove social media buttons" preventing the correct display of our social media buttons.
Currently, we are checking whether the respective scripts are blocked to determine whether the fallback should be applied instead of opening the popup. However, the resources for Twitter and Google+ don't appear to be blocked anymore which is why this issue has now resurfaced.
comment:3 Changed on 07/24/2014 at 12:14:47 PM by greiner
- Component changed from Unknown to User-Interface
- Priority changed from Unknown to P2
comment:4 Changed on 08/05/2014 at 03:56:55 PM by saroyanm
Works for me with ABP V 1.8.3.1204.
While I could reproduce the issue with ABP stable (V 1.8.3).
comment:5 Changed on 09/08/2014 at 08:52:08 AM by greiner
- Owner set to greiner
comment:6 Changed on 09/08/2014 at 08:57:37 AM by greiner
- Review URL(s) modified (diff)
- Status changed from new to reviewing
comment:7 Changed on 09/11/2014 at 08:45:52 AM by greiner
- Resolution set to fixed
- Status changed from reviewing to closed
comment:8 Changed on 10/13/2014 at 11:11:18 AM by trev
- Milestone set to Adblock-Plus-for-Firefox-next
- Platform changed from Opera to Firefox/Firefox Mobile
- Ready set
comment:9 Changed on 05/20/2015 at 02:22:39 PM by philll
- Platform changed from Firefox/Firefox Mobile to Firefox
Made Firefox and Firefox mobile available as seperate platforms.
1 - 24 Jul 2014 10:56:42 posted by Abhinav Sejpal
Hi Alexey, I am able to replicate this issue however Please update the replication steps,
you should apply following settings :-
Thanks for Video POC.