Opened on 07/25/2014 at 08:53:51 AM

Closed on 07/25/2014 at 10:16:04 AM

Last modified on 05/20/2015 at 02:22:39 PM

#1140 closed defect (fixed)

Remove references to "add-on bar" from Customization extension

Reported by: trev Assignee: saroyanm
Priority: P3 Milestone: Customizations-1.0.4-for-Adblock-Plus
Module: Extensions-for-Adblock-Plus Keywords:
Cc: saroyanm Blocked By:
Blocking: Platform: Firefox
Ready: yes Confidential: no
Tester: Verified working: no
Review URL(s):

http://codereview.adblockplus.org/5963413586968576/

Description (last modified by trev)

Environment

Adblock Plus 2.6.4.3852, Customizations for Adblock Plus 1.0.4a.78, Firefox 34.0a1 (nightly) on OS X.

How to reproduce

  1. Open Customization preferences.

Observed behaviour

A setting is called: "Toolbar/add-on bar item display." There is another called "Toolbar/add-on bar item left-click action."

Expected behaviour

The settings should be called "Toolbar item display" and "Toolbar item left-click action." The add-on bar has been removed from Firefox with the introduction of the Australis theme and we stopped referring to it in Adblock Plus.

Attachments (0)

Change History (6)

comment:1 Changed on 07/25/2014 at 09:02:13 AM by trev

  • Description modified (diff)

comment:2 Changed on 07/25/2014 at 09:09:06 AM by saroyanm

  • Owner set to saroyanm

comment:3 Changed on 07/25/2014 at 09:34:51 AM by saroyanm

  • Review URL(s) modified (diff)
  • Status changed from new to reviewing

comment:4 Changed on 07/25/2014 at 10:16:04 AM by saroyanm

  • Resolution set to fixed
  • Status changed from reviewing to closed

comment:5 Changed on 07/31/2014 at 08:38:04 AM by trev

  • Milestone set to Customizations-for-Adblock-Plus-next

comment:6 Changed on 05/20/2015 at 02:22:39 PM by philll

  • Platform changed from Firefox/Firefox Mobile to Firefox

Made Firefox and Firefox mobile available as seperate platforms.

Add Comment

Modify Ticket

Change Properties
Action
as closed .
The resolution will be deleted. Next status will be 'reopened'.
to The owner will be changed from saroyanm.
 
Note: See TracTickets for help on using tickets.