Opened on 07/25/2014 at 12:33:57 PM

Closed on 11/27/2014 at 02:46:49 PM

Last modified on 12/11/2014 at 02:02:38 PM

#1148 closed defect (fixed)

ABP on chrome blocks ads but IE doesnt

Reported by: passbrains Assignee: sergz
Priority: P2 Milestone: Adblock-Plus-for-Internet-Explorer-1.3
Module: Adblock-Plus-for-Internet-Explorer Keywords:
Cc: Blocked By:
Blocking: Platform: Internet Explorer
Ready: yes Confidential: no
Tester: Verified working: no
Review URL(s):

​http://codereview.adblockplus.org/6433575100481536/

Description (last modified by oleksandr)

Adapted from ​https://www.passbrains.com/dashboard/view-ticket.php?ticket_no=AIN-26

Environment

Windows 7 64bit Internet Explorer 8 English
ABP version 1.2.636

How to reproduce

  1. Install ABP for IE version 1.2.636 and ABP for Chrome version 1.8.3.1204.
  2. Launch link in both browsers

​http://seattletimes.com/html/larrystone/2023753540_stone03xml.html

Observed behaviour

IE ABP doesnt block ads on that page.

Expected behaviour

IE ABP should also block ads like Chrome ABP

Attachments (2)

1618_1406123001_Chrome.PNG​ (51.0 KB) - added by passbrains on 07/25/2014 at 12:33:59 PM.
1618_1406123001_IE.PNG​ (232.7 KB) - added by passbrains on 07/25/2014 at 12:34:00 PM.

Download all attachments as: .zip

Change History (8)

Changed on 07/25/2014 at 12:33:59 PM by passbrains

Changed on 07/25/2014 at 12:34:00 PM by passbrains

comment:1 Changed on 10/26/2014 at 05:29:45 PM by oleksandr

  • Component changed from Unknown to Adblock-Plus-for-Internet-Explorer
  • Description modified (diff)
  • Priority changed from Unknown to P2
  • Ready set

comment:2 Changed on 10/29/2014 at 09:51:27 AM by oleksandr

  • Owner set to sergz

comment:3 Changed on 11/03/2014 at 11:33:19 AM by sergz

The bug is in CFilterElementHide.

  • IHTMLElement::getAttribute sometimes returns not only BSTR or integer but also IDispatch. For example, for the tag like <some-tag on-some-event="do();"/> the value of on-some-event is IDispatch which toString() method returns function(event){\ndo();\n}. The selector in filter is ##a\[onmousedown^="this.href='http://paid.outbrain.com/network/redir?"]\[target="_blank"]
  • the selector ##a\[onmousedown^="this.href='http://paid.outbrain.com/network/redir?"]\[target="_blank"] + .ob_source is not properly applied
Last edited on 11/03/2014 at 11:36:03 AM by sergz

comment:4 Changed on 11/10/2014 at 12:29:14 PM by sergz

  • Review URL(s) modified (diff)
  • Status changed from new to reviewing

comment:5 Changed on 11/27/2014 at 02:46:49 PM by sergz

  • Resolution set to fixed
  • Status changed from reviewing to closed

comment:6 Changed on 12/11/2014 at 02:02:38 PM by oleksandr

  • Milestone set to Adblock-Plus-for-Internet-Explorer-next

Add Comment

Modify Ticket

Change Properties
Action
as closed .
The resolution will be deleted. Next status will be 'reopened'.
to The owner will be changed from sergz.
Attachments ↑ Description ↑
 
Note: See TracTickets for help on using tickets.