Opened on 07/26/2014 at 07:45:25 PM

Closed on 07/30/2014 at 02:18:03 PM

Last modified on 05/20/2015 at 02:22:39 PM

#1155 closed change (fixed)

Don't allow displaying icon text with Australis theme

Reported by: trev Assignee: saroyanm
Priority: P4 Milestone: Customizations-1.0.4-for-Adblock-Plus
Module: Extensions-for-Adblock-Plus Keywords:
Cc: Blocked By:
Blocking: Platform: Firefox
Ready: yes Confidential: no
Tester: Verified working: no
Review URL(s):

http://codereview.adblockplus.org/4744516900749312

Description

Background

Recent Firefox versions introduced the Australis theme. This theme no longer supports displaying toolbar icons with text, switching on text display by means of Customization for Adblock Plus causes various display issues (see #1079).

What to change

Don't display "Toolbar item display" option in Customization for Adblock Plus when the Australis theme is active, keep it in older Firefox versions and SeaMonkey. We can check whether the resource:///modules/CustomizableUI.jsm module exists to see whether the Australis theme is active.

Attachments (0)

Change History (7)

comment:1 Changed on 07/28/2014 at 08:26:56 AM by saroyanm

  • Owner set to saroyanm

comment:2 Changed on 07/28/2014 at 09:20:05 AM by saroyanm

  • Owner saroyanm deleted

comment:3 Changed on 07/28/2014 at 10:10:28 AM by saroyanm

  • Owner set to saroyanm

comment:4 Changed on 07/28/2014 at 08:04:42 PM by saroyanm

  • Review URL(s) modified (diff)
  • Status changed from new to reviewing

comment:5 Changed on 07/30/2014 at 02:18:03 PM by saroyanm

  • Resolution set to fixed
  • Status changed from reviewing to closed

comment:6 Changed on 07/30/2014 at 02:38:18 PM by trev

  • Milestone set to Customizations-for-Adblock-Plus-next

comment:7 Changed on 05/20/2015 at 02:22:39 PM by philll

  • Platform changed from Firefox/Firefox Mobile to Firefox

Made Firefox and Firefox mobile available as seperate platforms.

Add Comment

Modify Ticket

Change Properties
Action
as closed .
The resolution will be deleted. Next status will be 'reopened'.
to The owner will be changed from saroyanm.
 
Note: See TracTickets for help on using tickets.