Opened on 08/10/2014 at 04:38:58 AM
Closed on 01/10/2015 at 12:59:48 AM
Last modified on 05/20/2015 at 02:22:39 PM
#1192 closed defect (rejected)
"Disable on this page only" applies to all YouTube videos
Reported by: | Gingerbread Man | Assignee: | |
---|---|---|---|
Priority: | P3 | Milestone: | |
Module: | Adblock-Plus-for-Firefox | Keywords: | |
Cc: | mapx, trev | Blocked By: | |
Blocking: | Platform: | Firefox | |
Ready: | no | Confidential: | no |
Tester: | Verified working: | no | |
Review URL(s): |
Description
Environment
Firefox 31.0 • Adblock Plus 2.6.4
How to reproduce
- Go to literally any YouTube video, e.g. https://www.youtube.com/watch?v=ljWcpj8N6ws
- Click the Adblock Plus icon and choose "Disable on this page only".
Observed behavior
The following whitelist filter is added, which applies to all YouTube videos, not just that particular page.
@@|https://www.youtube.com/watch?$document
Expected behavior
The following whitelist filter should be added instead, so that it only applies to that particular page.
@@|https://www.youtube.com/watch?v=ljWcpj8N6ws$document
Attachments (0)
Change History (5)
comment:1 Changed on 08/11/2014 at 08:50:40 AM by mapx
- Cc mapx added
comment:2 Changed on 08/18/2014 at 03:06:17 PM by barbaz
comment:3 Changed on 08/18/2014 at 09:35:08 PM by barbaz
I'm not an ABP developer but I see two problems with this:
1) You shouldn't assume that the v parameter is always first...
2) Sometimes it's better to disable on a page independent of URL parameters. To work around this maybe there could be a separate menu item, or an about:config preference which specifies whether "Disable on this page only" should strip URL parameters.
Also, shouldn't the expected filter be more like
@@|https://www.youtube.com/watch?v=ljWcpj8N6ws^$document
to get closer to the desired restriction of either character & or end of address after the v parameter?
comment:4 Changed on 01/10/2015 at 12:59:48 AM by trev
- Cc trev added
- Resolution set to rejected
- Status changed from new to closed
Indeed, this is by design - normally, "this page" should really mean "this page", regardless of any parameters. The fact that the concept doesn't quite work for YouTube merely reflects the fact that defining a page is hard given dynamic websites. Still, I am convinced that YouTube's is a rare scenario and removing parameters does more good than harm. In the long term, we probably want to remove that option altogether and only keep per-domain whitelisting which is less confusing.
comment:5 Changed on 05/20/2015 at 02:22:39 PM by philll
- Platform changed from Firefox/Firefox Mobile to Firefox
Made Firefox and Firefox mobile available as seperate platforms.
nvm