Opened on 08/12/2014 at 11:16:36 AM

Closed on 09/01/2014 at 11:08:50 AM

Last modified on 12/12/2014 at 09:39:40 AM

#1196 closed change (fixed)

Fix dealing with boolean VARIANT

Reported by: sergz Assignee: sergz
Priority: P3 Milestone: Adblock-Plus-for-Internet-Explorer-1.3
Module: Adblock-Plus-for-Internet-Explorer Keywords:
Cc: Blocked By:
Blocking: Platform: Internet Explorer
Ready: yes Confidential: no
Tester: Verified working: no
Review URL(s):

​http://codereview.adblockplus.org/6248869830590464/

Description

Background

In src/plugin/PluginUserSettings.cpp we set the value of variant by implicitly converting it from C++ bool to VARIANT_BOOL, which is wrong. In COM world we should use VARIANT_TRUE which is -1.

Attachments (0)

Change History (4)

comment:1 Changed on 09/01/2014 at 11:08:50 AM by sergz

  • Resolution set to fixed
  • Status changed from new to closed

comment:2 Changed on 10/13/2014 at 11:20:57 AM by trev

  • Milestone set to Adblock-Plus-for-Internet-Explorer-next

This landed in ​https://hg.adblockplus.org/adblockplusie/rev/a3d1abe48760.

comment:3 Changed on 12/12/2014 at 09:37:50 AM by fhd

  • Priority changed from Unknown to P4
  • Ready set

Posthumously setting priority and ready - P3 seems about appropriate here.

comment:4 Changed on 12/12/2014 at 09:39:40 AM by fhd

  • Priority changed from P4 to P3

Since I said P3, I'll actually set P3 :)

Add Comment

Modify Ticket

Change Properties
Action
as closed .
The resolution will be deleted. Next status will be 'reopened'.
to The owner will be changed from sergz.
Attachments ↑ Description ↑
 
Note: See TracTickets for help on using tickets.