Opened on 08/12/2014 at 02:22:18 PM
Closed on 08/12/2014 at 02:25:17 PM
Last modified on 08/12/2014 at 02:28:53 PM
#1199 closed change (rejected)
Read the frame structure using BINDSTRING_ROOTDOC_URL
Reported by: | fhd | Assignee: | |
---|---|---|---|
Priority: | P3 | Milestone: | |
Module: | Adblock-Plus-for-Internet-Explorer | Keywords: | |
Cc: | oleksandr | Blocked By: | |
Blocking: | Platform: | Internet Explorer | |
Ready: | no | Confidential: | no |
Tester: | Verified working: | no | |
Review URL(s): |
Description
We're currently using libadblockplus's ReferrerMapping to get the rough frame hierarchy for each request.
It seems that we can do much better than that on IE9 and upwards - there's BINDSTRING_ROOTDOC_URL. The downside would be that we need to keep the referrer mapping in place to stay compatible with IE8.
Attachments (0)
Change History (3)
comment:1 Changed on 08/12/2014 at 02:23:20 PM by fhd
- Cc oleksandr added
comment:2 Changed on 08/12/2014 at 02:25:17 PM by fhd
- Resolution set to rejected
- Status changed from new to closed
Actually, I filed the issue before thinking. We need the full frame hierarchy for each request - knowing the rootdoc URL shouldn't be any better than knowing the referrer...
comment:3 Changed on 08/12/2014 at 02:28:53 PM by oleksandr
Yes. And root document of an iframe within an iframe is the parent iframe, if I remember correctly. I can double check this.
Seems to me this'd be worth it. What do you think, Oleksandr?