Opened on 03/13/2014 at 12:16:51 AM
Closed on 04/07/2016 at 11:16:54 AM
#123 closed change (fixed)
Don't hard code the admin email address everywhere
| Reported by: | fhd | Assignee: | matze |
|---|---|---|---|
| Priority: | P3 | Milestone: | |
| Module: | Infrastructure | Keywords: | |
| Cc: | fred | Blocked By: | #112, #3206 |
| Blocking: | Platform: | Unknown | |
| Ready: | yes | Confidential: | no |
| Tester: | Unknown | Verified working: | no |
| Review URL(s): |
https://codereview.adblockplus.org/29329120/ |
||
Description
Background
We're currently hard coding the email address for the admins list (admins@adblockplus.org) all over our Puppet modules. This means that this list is receiving tons of pointless emails when someone is working with certain parts of the infrastructure locally.
What to change
We shouldn't hard code admins@adblockplus.org everywhere, it should be defined in one place. And furthermore, we shouldn't only use admins@adblockplus.org in production, and some dummy email address in the test environment. To achieve this, it probably makes sense to set the email address in the private module.
Attachments (0)
Change History (16)
comment:1 Changed on 04/19/2014 at 03:11:10 AM by poz2k4444
comment:2 Changed on 04/25/2014 at 08:40:52 AM by trev
- Owner set to poz2k4444
- Ready set
- Status changed from new to assigned
comment:3 Changed on 04/25/2014 at 08:41:45 AM by christian
- Cc cvervoorts@adblockplus.org added
comment:5 Changed on 04/26/2014 at 07:51:24 PM by poz2k4444
I couldn't rebase the git repo so I made another branch and a new pull request, the link is in the description
comment:6 Changed on 04/30/2014 at 09:50:33 AM by philll
- Status changed from assigned to new
The assigned state will be dropped by #403
comment:7 Changed on 10/06/2014 at 11:25:49 AM by matze
- Blocked By 112 added
- Platform set to Unknown
comment:8 Changed on 10/06/2014 at 11:26:45 AM by matze
With the integration of Hiera (see #112) this will become way easier to implement (as well as the removal of many more hard-coded values).
comment:9 Changed on 02/23/2015 at 11:10:29 AM by poz2k4444
- Cc cvervoorts@adblockplus.org removed
- Owner changed from poz2k4444 to matze
comment:10 Changed on 10/14/2015 at 03:32:53 PM by matze
- Blocked By 3206 added
comment:11 Changed on 10/14/2015 at 05:11:27 PM by matze
- Cc fred added
- Review URL(s) modified (diff)
- Status changed from new to reviewing
- Tester set to Unknown
comment:12 Changed on 10/14/2015 at 05:17:28 PM by matze
- Review URL(s) modified (diff)
comment:13 Changed on 10/14/2015 at 05:20:45 PM by matze
- Review URL(s) modified (diff)
comment:14 Changed on 10/15/2015 at 11:39:10 PM by matze
comment:15 Changed on 10/21/2015 at 07:22:31 PM by matze
comment:16 Changed on 04/07/2016 at 11:16:54 AM by matze
- Resolution set to fixed
- Status changed from reviewing to closed
I sent a pull request in github in this link:
https://github.com/adblockplus/infrastructure/pull/2
I pulled the last commit from the official mercurial repository to have the latest version in github.