Opened on 08/14/2014 at 02:00:01 PM
Closed on 11/07/2014 at 03:03:26 PM
Last modified on 12/11/2014 at 02:07:52 PM
#1230 closed defect (fixed)
Wrong Facebook/G+/Twitter icons on the first-run page
| Reported by: | trev | Assignee: | oleksandr |
|---|---|---|---|
| Priority: | P2 | Milestone: | Adblock-Plus-for-Internet-Explorer-1.3 |
| Module: | Adblock-Plus-for-Internet-Explorer | Keywords: | |
| Cc: | oleksandr | Blocked By: | |
| Blocking: | Platform: | Internet Explorer | |
| Ready: | yes | Confidential: | no |
| Tester: | Verified working: | no | |
| Review URL(s): |
http://codereview.adblockplus.org/5477003205541888/ |
||
Description
Environment
Adblock Plus for Internet Explorer 1.2
How to reproduce
- Install Adblock Plus for Internet Explorer 1.2
- Have a look at the sharing icons on the first-run page.
Observed behaviour
https://hg.adblockplus.org/adblockplusie/raw-file/b241d73f074d/html/static/img/social/facebook-old.png is being used as the Facebook icon. We stopped using that icon everywhere something like a year ago.
Expected behaviour
https://hg.adblockplus.org/adblockplusie/raw-file/b241d73f074d/html/static/img/social/facebook.png should be used as the Facebook icon. This icon is apparently being used on the settings page already.
Attachments (0)
Change History (5)
comment:1 Changed on 10/24/2014 at 02:46:50 PM by oleksandr
- Owner set to oleksandr
comment:2 Changed on 10/26/2014 at 04:54:42 PM by oleksandr
- Review URL(s) modified (diff)
- Status changed from new to reviewing
comment:4 Changed on 11/07/2014 at 03:03:26 PM by fhd
- Resolution set to fixed
- Status changed from reviewing to closed
Second change pushed. Devbuilds are working again, closing.
comment:5 Changed on 12/11/2014 at 02:07:52 PM by oleksandr
- Milestone set to Adblock-Plus-for-Internet-Explorer-1.3
Note: See
TracTickets for help on using
tickets.
Already pushed, but it broke the devbuilds: We need to remove the old icons from the installer, too. Added the review.