Opened on 08/15/2014 at 04:43:57 AM
Closed on 01/13/2015 at 03:04:35 PM
Last modified on 02/19/2015 at 07:38:55 AM
#1235 closed defect (fixed)
Adblock Plus entry in Control Panel has a generic installer icon
| Reported by: | Gingerbread Man | Assignee: | eric@adblockplus.org |
|---|---|---|---|
| Priority: | P3 | Milestone: | Adblock-Plus-for-Internet-Explorer-1.4 |
| Module: | Adblock-Plus-for-Internet-Explorer | Keywords: | |
| Cc: | Blocked By: | ||
| Blocking: | Platform: | Internet Explorer | |
| Ready: | yes | Confidential: | no |
| Tester: | Verified working: | no | |
| Review URL(s): | |||
Description
Environment
Windows XP SP3 • Adblock Plus 1.2
How to reproduce
- Open the Windows Control Panel, Add/Remove Programs section.
Observed behavior
The Adblock Plus entry has a generic installer icon.
Expected behavior
The Adblock Plus entry should have the ABP logo as its icon.
Attachments (0)
Change History (7)
comment:1 Changed on 12/11/2014 at 10:16:04 AM by oleksandr
- Ready set
comment:2 Changed on 01/05/2015 at 01:36:51 AM by eric@adblockplus.org
- Review URL(s) modified (diff)
comment:3 Changed on 01/05/2015 at 01:41:13 AM by eric@adblockplus.org
comment:4 Changed on 01/05/2015 at 01:41:41 AM by eric@adblockplus.org
- Status changed from new to reviewing
comment:5 Changed on 01/07/2015 at 10:33:01 PM by eric@adblockplus.org
- Owner set to eric@adblockplus.org
comment:6 Changed on 01/13/2015 at 03:04:35 PM by eric@adblockplus.org
- Resolution set to fixed
- Status changed from reviewing to closed
comment:7 Changed on 02/19/2015 at 07:38:55 AM by oleksandr
- Milestone set to Adblock-Plus-for-Internet-Explorer-1.4
Note: See
TracTickets for help on using
tickets.
The first review uses the existing "blocking.ico" icon file, which is the only appropriate icon in the source tree as of this writing.
When #1538 is ready, we should use a separate icon file for this resource that has multiple resolutions. A small icon is used in the line item within the listing, and a larger one appears at the bottom when the item is selected.