Opened on 08/18/2014 at 03:43:52 PM
Last modified on 10/09/2019 at 11:28:49 AM
#1244 reviewing change
Cleanup of sitescript module dependencies
| Reported by: | matze | Assignee: | matze |
|---|---|---|---|
| Priority: | Unknown | Milestone: | |
| Module: | Sitescripts | Keywords: | reports sitescripts |
| Cc: | fhd, greiner | Blocked By: | |
| Blocking: | Platform: | Unknown | |
| Ready: | no | Confidential: | no |
| Tester: | Unknown | Verified working: | no |
| Review URL(s): | |||
Description (last modified by matze)
Background
In the context of #240, we've already discovered a few unused import statements in the sitescripts.reports module. This ticket here shall serve as a context for cleanups done while migrating the reports.adblockplus.org service to a distinct server.
In http://codereview.adblockplus.org/4805960266678272/, the creation of this ticket was requested by @trev. Further patch-sets may follow, however.
Please also note that testing of this (minor) changes will be done in the context of #240. Thus, there shall be no changes in this context that are not related to this ticket.
Attachments (0)
Change History (7)
comment:2 Changed on 11/25/2014 at 05:32:12 PM by matze
- Owner changed from matze to AAlvz
comment:3 Changed on 11/25/2014 at 06:46:08 PM by AAlvz
LGTM, the reports can be send without issues and can be seen afterwards. Just as before
comment:4 Changed on 11/25/2014 at 06:46:23 PM by AAlvz
- Owner changed from AAlvz to matze
comment:5 Changed on 01/26/2015 at 12:45:07 PM by matze
- Status changed from new to reviewing
comment:6 Changed on 12/21/2017 at 11:28:41 AM by fhd
- Cc trev removed
comment:7 Changed on 10/09/2019 at 11:28:49 AM by greiner
- Cc greiner added
- Component changed from Unknown to Sitescripts
- Tester set to Unknown
Note: See
TracTickets for help on using
tickets.
@AAlvz Please use your current setup for reports.adblockplus.org (see #240), apply the patch-set from this ticket's Review URL(s), and perform the same tests as done for the reports server - in order to verify that the changes do not affect the behavior in any way.