Opened on 08/21/2014 at 06:37:17 PM

Closed on 08/22/2014 at 08:34:12 AM

Last modified on 05/20/2015 at 02:22:39 PM

#1255 closed defect (duplicate)

Social buttons broken on first-run page when activating social blocking list

Reported by: arthur Assignee:
Priority: P2 Milestone:
Module: Adblock-Plus-for-Firefox Keywords:
Cc: Blocked By:
Blocking: Platform: Firefox
Ready: yes Confidential: no
Tester: Verified working: no
Review URL(s):

Description

Environment

Firefox 31
Adblock Plus 2.6.4.3859

How to reproduce

  1. Open the firs-run page in Firefox by going to chrome://adblockplus/content/ui/firstRun.html
  2. Activate the social blocking list if necessary
  3. Click either the Google Plus or Twitter sharing button

Observed behaviour

The sharing overlay appears but the buttons are blocked. Sharing/liking isn't possible.

Expected behaviour

When clicking on the share buttons after activating the social blocking list, the user should be taken to the respective social media page of Adblock Plus like with the Facebook botton.

This is also happening in Chrome.

Via Passbrains: https://www.passbrains.com/dashboard/view-ticket.php?ticket_no=ARE-21

Attachments (0)

Change History (4)

comment:1 in reply to: ↑ description ; follow-up: Changed on 08/22/2014 at 04:39:34 AM by barbaz

I can confirm that this happens with latest dev build of ABP on latest SeaMonkey release. But...

Replying to arthur:

The sharing overlay appears but the buttons are blocked. Sharing/liking isn't possible.

Isn't that the whole point of a social *blocking* list?
I would think that the issue here is that the Facebook button on the first-run page is *not* getting blocked - and that would be a filterlist issue, not an ABP issue.

comment:2 in reply to: ↑ 1 Changed on 08/22/2014 at 08:14:00 AM by arthur

Replying to barbaz:

I would think that the issue here is that the Facebook button on the first-run page is *not* getting blocked - and that would be a filterlist issue, not an ABP issue.

When a user activates the social blocking list, it blocks all like, share, follow buttons and such that (could potentially) track you. That's why you don't see those buttons in the sharing overlay. Instead of the overlay the social media buttons should simply link to the social media pages so the user can go there and like/follow/+1 that page if (s)he still wants to. This is currently only working for the Facebook button.

comment:3 Changed on 08/22/2014 at 08:34:12 AM by philll

  • Resolution set to duplicate
  • Status changed from new to closed

See #1223

comment:4 Changed on 05/20/2015 at 02:22:39 PM by philll

  • Platform changed from Firefox/Firefox Mobile to Firefox

Made Firefox and Firefox mobile available as seperate platforms.

Add Comment

Modify Ticket

Change Properties
Action
as closed .
The resolution will be deleted. Next status will be 'reopened'.
to The owner will be changed from (none).
 
Note: See TracTickets for help on using tickets.