Opened on 08/22/2014 at 01:34:05 PM
Closed on 08/29/2014 at 02:56:34 PM
#1259 closed change (fixed)
Block while checking whether ABP is disabled on YouTube
| Reported by: | sebastian | Assignee: | sebastian |
|---|---|---|---|
| Priority: | P1 | Milestone: | Adblock-Plus-1.8.4-for-Chrome-Opera-Safari |
| Module: | Platform | Keywords: | |
| Cc: | Blocked By: | ||
| Blocking: | #1258 | Platform: | Safari |
| Ready: | yes | Confidential: | no |
| Tester: | Verified working: | no | |
| Review URL(s): | |||
Description
Background
We use asynchronous messaging to check whether Adblock Plus is disabled before modifying the page in order to block video ads on YouTube. While waiting for the response YouTube's JavaScript already runs.
But in order to fix #1258 we have to define a property on the window object, before YouTube's JavaScript runs.
It is the same with the code disabling the history API, which we currently run no matter whether Adblock Plus is disabled on YouTube.
What to change
Use synchronous messaging to block execution while checking whether Adblock Plus is disabled on YouTube.
Attachments (0)
Change History (3)
comment:1 Changed on 08/22/2014 at 02:01:17 PM by sebastian
- Review URL(s) modified (diff)
- Status changed from new to reviewing
comment:2 Changed on 08/27/2014 at 11:30:23 AM by sebastian
- Milestone set to Adblock-Plus-for-Chrome-Opera-Safari-next
- Priority changed from P2 to P1
comment:3 Changed on 08/29/2014 at 02:56:34 PM by sebastian
- Resolution set to fixed
- Status changed from reviewing to closed
Note: See
TracTickets for help on using
tickets.
https://hg.adblockplus.org/adblockpluschrome/rev/011e83ccda0c